From: Alex Deucher <alexdeucher@gmail.com>
To: Wolfram Sang <wsa-dev@sang-engineering.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Linux I2C" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 4/5] gpu: drm: radeon: radeon_i2c: don't print error when adding adapter fails
Date: Wed, 10 Aug 2016 14:10:30 -0400 [thread overview]
Message-ID: <CADnq5_OYiBmpwJBz3CscnxcR8dC0UNmz+5OCXM-aFFFb5PV5zQ@mail.gmail.com> (raw)
In-Reply-To: <1470742232-12559-5-git-send-email-wsa-dev@sang-engineering.com>
On Tue, Aug 9, 2016 at 7:30 AM, Wolfram Sang
<wsa-dev@sang-engineering.com> wrote:
> The core will do this for us now.
>
> Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Applied patches 1, 5.
Thanks,
Alex
> ---
> drivers/gpu/drm/radeon/radeon_i2c.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
> index 9590bcd321c09a..021aa005623f80 100644
> --- a/drivers/gpu/drm/radeon/radeon_i2c.c
> +++ b/drivers/gpu/drm/radeon/radeon_i2c.c
> @@ -938,10 +938,8 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev,
> "Radeon i2c hw bus %s", name);
> i2c->adapter.algo = &radeon_i2c_algo;
> ret = i2c_add_adapter(&i2c->adapter);
> - if (ret) {
> - DRM_ERROR("Failed to register hw i2c %s\n", name);
> + if (ret)
> goto out_free;
> - }
> } else if (rec->hw_capable &&
> radeon_hw_i2c &&
> ASIC_IS_DCE3(rdev)) {
> @@ -950,10 +948,8 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev,
> "Radeon i2c hw bus %s", name);
> i2c->adapter.algo = &radeon_atom_i2c_algo;
> ret = i2c_add_adapter(&i2c->adapter);
> - if (ret) {
> - DRM_ERROR("Failed to register hw i2c %s\n", name);
> + if (ret)
> goto out_free;
> - }
> } else {
> /* set the radeon bit adapter */
> snprintf(i2c->adapter.name, sizeof(i2c->adapter.name),
> --
> 2.8.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-10 18:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 11:30 [PATCH 0/5] gpu: don't print error when adding adapter fails Wolfram Sang
2016-08-09 11:30 ` [PATCH 1/5] gpu: drm: amd: amdgpu: amdgpu_i2c: " Wolfram Sang
2016-08-09 11:30 ` [PATCH 2/5] gpu: drm: mediatek: mtk_hdmi_ddc: " Wolfram Sang
2016-08-09 11:30 ` [PATCH 3/5] gpu: drm: msm: hdmi: hdmi_i2c: " Wolfram Sang
2016-08-09 11:30 ` [PATCH 4/5] gpu: drm: radeon: radeon_i2c: " Wolfram Sang
2016-08-10 18:10 ` Alex Deucher [this message]
2016-08-09 11:30 ` [PATCH 5/5] gpu: drm: rockchip: inno_hdmi: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_OYiBmpwJBz3CscnxcR8dC0UNmz+5OCXM-aFFFb5PV5zQ@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).