From: Hoan Tran <hotran@apm.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Loc Ho <lho@apm.com>, Keyur Chudgar <kchudgar@apm.com>
Subject: Re: [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox
Date: Fri, 2 Jun 2017 13:58:03 -0700 [thread overview]
Message-ID: <CAFHUOYxYLwWpz__Wu_XYbQeuMDf0uKEcwJJLj2QW7OVM1x8JBA@mail.gmail.com> (raw)
In-Reply-To: <20170602203128.uxuy5lgzyopvvpkr@ninjato>
On Fri, Jun 2, 2017 at 1:31 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Mon, Apr 24, 2017 at 11:00:26AM -0700, Hoan Tran wrote:
>> This patch adds ACPI support by using PCC mailbox communication
>> interface.
>>
>> Signed-off-by: Hoan Tran <hotran@apm.com>
>
> Please make use checkpatch:
>
> WARNING: braces {} are not necessary for single statement blocks
> #149: FILE: drivers/i2c/busses/i2c-xgene-slimpro.c:242:
> + if (!acpi_disabled) {
> + mbox_chan_txdone(ctx->mbox_chan, 0);
> + }
>
> Fixed that and applied to for-next, thanks!
Thanks, Wolfram!
Regards,
Hoan
>
> BTW is there anyone inside apm.com who is willing to take over maintainership
> for this driver? This person needs to review patches thoroughly, yet it usually
> means patches will go in faster.
>
> Regards,
>
> Wolfram
>
next prev parent reply other threads:[~2017-06-02 20:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 18:00 [PATCH v2 0/2] i2c: xgene-slimpro: Add ACPI support Hoan Tran
2017-04-24 18:00 ` [PATCH v2 1/2] i2c: xgene-slimpro: Use a single function to send command message Hoan Tran
2017-06-02 20:28 ` Wolfram Sang
2017-04-24 18:00 ` [PATCH v2 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox Hoan Tran
2017-06-02 20:31 ` Wolfram Sang
2017-06-02 20:37 ` Loc Ho
2017-06-02 20:58 ` Hoan Tran [this message]
2017-05-15 23:06 ` [PATCH v2 0/2] i2c: xgene-slimpro: Add ACPI support Hoan Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFHUOYxYLwWpz__Wu_XYbQeuMDf0uKEcwJJLj2QW7OVM1x8JBA@mail.gmail.com \
--to=hotran@apm.com \
--cc=kchudgar@apm.com \
--cc=lho@apm.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).