From: Brendan Higgins <brendanhiggins@google.com>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
linux-i2c@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors
Date: Fri, 21 Sep 2018 15:30:42 -0700 [thread overview]
Message-ID: <CAFd5g46==5HG2stvuVfOUtsSW37SvLN6cCmOhRSxibrUpxb8aA@mail.gmail.com> (raw)
In-Reply-To: <f5943177-6f1b-9344-3821-2aac001ff45d@linux.intel.com>
On Fri, Sep 21, 2018 at 3:26 PM Jae Hyun Yoo
<jae.hyun.yoo@linux.intel.com> wrote:
>
<snip>
>
> > + if (base_clk_divisor > ASPEED_I2CD_TIME_BASE_DIVISOR_MASK) {
> > + base_clk_divisor = ASPEED_I2CD_TIME_BASE_DIVISOR_MASK;
> > + clk_low = clk_high_low_mask;
> > + clk_high = clk_high_low_mask;
> > + dev_err(dev,
> > + "clamping clock divider: divider requested, %u, is greater than largest possible divider, %u.",
>
> Please put a newline character at the end of the string.
I always forget to do that. I wonder if anyone has considered adding a
warning for this to checkpatch?
>
> Thanks,
> Jae
>
> [....]
next prev parent reply other threads:[~2018-09-21 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 22:10 [PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors Brendan Higgins
2018-09-21 22:26 ` Jae Hyun Yoo
2018-09-21 22:30 ` Brendan Higgins [this message]
2018-09-22 14:16 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFd5g46==5HG2stvuVfOUtsSW37SvLN6cCmOhRSxibrUpxb8aA@mail.gmail.com' \
--to=brendanhiggins@google.com \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).