From: Barry Song <21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
DL-SHA-WorkGroupLinux
<workgroup.linux-kQvG35nSl+M@public.gmane.org>,
Zhiwu Song <Zhiwu.Song-kQvG35nSl+M@public.gmane.org>,
Barry Song <Baohua.Song-kQvG35nSl+M@public.gmane.org>
Subject: Re: [PATCH 1/5] i2c: sirf: reset i2c controller early after we get a noack
Date: Tue, 20 Aug 2013 06:49:54 +0800 [thread overview]
Message-ID: <CAGsJ_4wgUOSeufUtHOj0UGHZ-2iOVbxqPTWoTEKd9mdVNPC9OA@mail.gmail.com> (raw)
In-Reply-To: <20130819180540.GD8626@katana>
2013/8/20 Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>:
>
>> + while (readl(siic->base + SIRFSOC_I2C_CTRL) & SIRFSOC_I2C_RESET)
>> + cpu_relax();
>
> Are you sure you want no timeout here? Same for patch 2/5.
the real situation is that timeout never happen for resetting the i2c
controller, in pressure test, this loop will always break.
>
-barry
next prev parent reply other threads:[~2013-08-19 22:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 9:11 [PATCH 0/5] i2c: sirf: a bundle of fixes for stability Barry Song
[not found] ` <1376385091-30597-1-git-send-email-Baohua.Song-kQvG35nSl+M@public.gmane.org>
2013-08-13 9:11 ` [PATCH 1/5] i2c: sirf: reset i2c controller early after we get a noack Barry Song
[not found] ` <1376385091-30597-2-git-send-email-Baohua.Song-kQvG35nSl+M@public.gmane.org>
2013-08-19 18:05 ` Wolfram Sang
2013-08-19 22:49 ` Barry Song [this message]
2013-08-13 9:11 ` [PATCH 2/5] i2c: sirf: we need to wait I2C_RESET status in resume Barry Song
2013-08-13 9:11 ` [PATCH 3/5] i2c: sirf: fix the typo for setting bitrate to less than 100k Barry Song
2013-08-13 9:11 ` [PATCH 4/5] i2c: sirfsoc: support reverse direction of address Barry Song
[not found] ` <1376385091-30597-5-git-send-email-Baohua.Song-kQvG35nSl+M@public.gmane.org>
2013-08-19 18:06 ` Wolfram Sang
2013-08-20 2:30 ` Barry Song
[not found] ` <CAGsJ_4xoPCJyWZ=_nN6wZBAy2qMER=cKOqY_t8K_jAX8fZWGmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-08-28 9:41 ` Wolfram Sang
2013-08-28 12:00 ` Barry Song
2013-08-13 9:11 ` [PATCH 5/5] i2c: sirf: retry 3 times as sometimes we get random noack and timeout Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGsJ_4wgUOSeufUtHOj0UGHZ-2iOVbxqPTWoTEKd9mdVNPC9OA@mail.gmail.com \
--to=21cnbao-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Baohua.Song-kQvG35nSl+M@public.gmane.org \
--cc=Zhiwu.Song-kQvG35nSl+M@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=workgroup.linux-kQvG35nSl+M@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).