From: Barry Song <21cnbao@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, Laxman Dewangan <ldewangan@nvidia.com>
Cc: Barry Song <21cnbao@gmail.com>, Donglin Peng <pengdonglin137@163.com>
Subject: Re: [PATCH] i2c: tegra: drop duplicated code for assigning algo
Date: Mon, 21 Sep 2015 11:20:03 +0800 [thread overview]
Message-ID: <CAGsJ_4zT-AFOvvFPo3U9d4ijQsjTD++QS3KXsOhx+-mMPkJ1HA@mail.gmail.com> (raw)
In-Reply-To: <1441595335-31672-1-git-send-email-21cnbao@gmail.com>
ping...
2015-09-07 11:08 GMT+08:00 Barry Song <21cnbao@gmail.com>:
> This code is repeated in probe:
> i2c_dev->adapter.algo = &tegra_i2c_algo;
>
> Cc: Donglin Peng <pengdonglin137@163.com>
> Signed-off-by: Barry Song <21cnbao@gmail.com>
> ---
> drivers/i2c/busses/i2c-tegra.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index 78a3668..9ab720b 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -825,7 +825,6 @@ static int tegra_i2c_probe(struct platform_device *pdev)
> i2c_dev->adapter.class = I2C_CLASS_DEPRECATED;
> strlcpy(i2c_dev->adapter.name, "Tegra I2C adapter",
> sizeof(i2c_dev->adapter.name));
> - i2c_dev->adapter.algo = &tegra_i2c_algo;
> i2c_dev->adapter.dev.parent = &pdev->dev;
> i2c_dev->adapter.nr = pdev->id;
> i2c_dev->adapter.dev.of_node = pdev->dev.of_node;
> --
> 1.9.1
>
next prev parent reply other threads:[~2015-09-21 3:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 3:08 [PATCH] i2c: tegra: drop duplicated code for assigning algo Barry Song
2015-09-21 3:20 ` Barry Song [this message]
2015-10-20 15:40 ` Wolfram Sang
2015-10-23 20:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGsJ_4zT-AFOvvFPo3U9d4ijQsjTD++QS3KXsOhx+-mMPkJ1HA@mail.gmail.com \
--to=21cnbao@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=pengdonglin137@163.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).