From mboxrd@z Thu Jan 1 00:00:00 1970 From: Naveen Krishna Ch Subject: Re: [PATCH 1/2 v2] i2c: exynos5: add support for HSI2C on Exynos5260 SoC Date: Tue, 26 Nov 2013 17:23:56 +0530 Message-ID: References: <1385100726-32165-1-git-send-email-ch.naveen@samsung.com> <1385439977-19077-1-git-send-email-ch.naveen@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Sachin Kamat Cc: Naveen Krishna Chatradhi , linux-i2c@vger.kernel.org, sjg@chromium.org, LKML , linux-samsung-soc , Wolfram Sang , Ben Dooks , Grant Likely , Mark Brown , Doug Anderson , cpgs@samsung.com, Tomasz Figa List-Id: linux-i2c@vger.kernel.org Hello Sachin, On 26 November 2013 16:59, Sachin Kamat wrote: > On 26 November 2013 09:56, Naveen Krishna Chatradhi > wrote: >> This patch adds new compatible to support HSI2C module on Exynos5260 >> HSI2C module on Exynos5260 needs to be reset during during initialization. >> >> Signed-off-by: Naveen Krishna Chatradhi > [snip] >> >> Required properties: >> - compatible: value should be. >> - -> "samsung,exynos5-hsi2c", for i2c compatible with exynos5 hsi2c. >> + -> "samsung,exynos5-hsi2c", for i2c compatible with HSI2C available on >> + Exynos5250/5420 SoCs. The first HSI2C module is available on Exynos5 SoCs from Samsung. Hence, "samsung,exynos5-hsi2c" HSI2C Module on Exynos5250 and Exynos5420 was exactly similar HSI2C Module on Exynos5260 differs in hardware. Hence, "samsung,exynos5260-hsi2c". And as the new variants come we use "samsung,exynosXXX-hsi2c" or we can go by "samsung,exynos5-hsi2c-v2" Changing an existing compatible needs modification in the DT nodes as well. I will change the compatible string, if anyone else also thinks its wise. > > This string could be made more specific ("samsung,exynos5250-hsi2c") > now that we have variants for this. > >> + -> "samsung,exynos5260-hsi2c", for i2c compatible with HSI2C available >> + on Exynos5260 SoCs. >> + >> - reg: physical base address of the controller and length of memory mapped >> region. >> - interrupts: interrupt number to the cpu. >> diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c >> index da39ff0..497ff91 100644 >> --- a/drivers/i2c/busses/i2c-exynos5.c >> +++ b/drivers/i2c/busses/i2c-exynos5.c >> @@ -184,14 +184,35 @@ struct exynos5_i2c { >> * 2. Fast speed upto 1Mbps >> */ >> int speed_mode; >> + >> + /* Version of HS-I2C Hardware */ >> + unsigned int version; >> +}; >> + >> +enum hsi2c_version { >> + EXYNOS_5, > > ditto. > >> + EXYNOS_5260 >> }; >> > > -- > With warm regards, > Sachin > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Shine bright, (: Nav :)