From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Akhil R <akhilrajeev@nvidia.com>
Cc: Christian Koenig <christian.koenig@amd.com>,
Dmitry Osipenko <digetx@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jon Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Wolfram Sang <wsa@kernel.org>, Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] i2c: smbus: Use device_*() functions instead of of_*()
Date: Wed, 12 Jan 2022 17:41:08 +0200 [thread overview]
Message-ID: <CAHp75Vd=gxF9jFMvRw3qM9rfsxxCsO8qYXKVheuhjOV7ypU9og@mail.gmail.com> (raw)
In-Reply-To: <1641996862-26960-4-git-send-email-akhilrajeev@nvidia.com>
On Wed, Jan 12, 2022 at 4:15 PM Akhil R <akhilrajeev@nvidia.com> wrote:
>
> Change of_*() functions to device_*() for firmware agnostic usage.
> This allows to have smbus_alert interrupt without any changes
the smbus_alert
> in the controller drivers using ACPI table.
the ACPI
...
This change reveals potential issue:
> - irq = of_irq_get_byname(adapter->dev.of_node, "smbus_alert");
> + irq = device_irq_get_byname(adapter->dev.parent, "smbus_alert");
> if (irq <= 0)
I guess this '= 0' part should be fixed first.
> return irq;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-01-12 15:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 14:14 [PATCH v2 0/3] Enable named interrupt smbus-alert for ACPI Akhil R
2022-01-12 14:14 ` [PATCH v2 1/3] device property: Add device_irq_get_byname Akhil R
2022-01-12 15:53 ` Andy Shevchenko
2022-01-12 16:13 ` Rafael J. Wysocki
2022-01-13 4:41 ` Akhil R
2022-01-12 14:14 ` [PATCH v2 2/3] docs: firmware-guide: ACPI: Add named interrupt doc Akhil R
2022-01-12 15:48 ` Andy Shevchenko
2022-01-12 14:14 ` [PATCH v2 3/3] i2c: smbus: Use device_*() functions instead of of_*() Akhil R
2022-01-12 15:41 ` Andy Shevchenko [this message]
2022-01-20 9:48 ` Akhil R
2022-01-20 10:12 ` Andy Shevchenko
2022-01-20 10:29 ` Akhil R
2022-01-20 10:43 ` Andy Shevchenko
2022-01-20 11:30 ` Akhil R
2022-01-20 11:30 ` Uwe Kleine-König
2022-01-12 15:55 ` [PATCH v2 0/3] Enable named interrupt smbus-alert for ACPI Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vd=gxF9jFMvRw3qM9rfsxxCsO8qYXKVheuhjOV7ypU9og@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=christian.koenig@amd.com \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).