From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Akhil R <akhilrajeev@nvidia.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Christian Koenig" <christian.koenig@amd.com>,
"Dmitry Osipenko" <digetx@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jon Hunter" <jonathanh@nvidia.com>,
"Laxman Dewangan" <ldewangan@nvidia.com>,
"Len Brown" <lenb@kernel.org>,
"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Wolfram Sang" <wsa@kernel.org>
Subject: Re: [PATCH v3 2/3] docs: firmware-guide: ACPI: Add named interrupt doc
Date: Thu, 20 Jan 2022 17:03:14 +0200 [thread overview]
Message-ID: <CAHp75VehSCxszDV3UQCEnPk7OCXRabRMJEStjpCamBG6X1iaCw@mail.gmail.com> (raw)
In-Reply-To: <1642686255-25951-3-git-send-email-akhilrajeev@nvidia.com>
On Thu, Jan 20, 2022 at 3:45 PM Akhil R <akhilrajeev@nvidia.com> wrote:
>
> Added details and example for named interrupts in the ACPI table.
Added details and example for --> Add a detailed example of the
...
> + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) {
> + 0x20,
I would think of splitting this to two separate entries in between of
which the GpioInt() resource is provided. It will explicitly show that
you describe the case only for Interrupt(). Something like
Interrupt (...) { 0x20 }
GpioInt(...) { ... }
Interrupt (...) { 0x24 }
But it's up to you.
> + 0x24
> + }
...
> +The driver can call the function - device_irq_get_byname() with the device
> +and interrupt name as arguments to get the corresponding IRQ number.
Needs switch to fwnode as per comment against the previous patch.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-01-20 15:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 13:44 [PATCH v3 0/3] Enable named interrupt smbus-alert for ACPI Akhil R
2022-01-20 13:44 ` [PATCH v3 1/3] device property: Add device_irq_get_byname Akhil R
2022-01-20 14:57 ` Andy Shevchenko
2022-01-21 9:18 ` Akhil R
2022-01-21 10:16 ` Andy Shevchenko
2022-01-21 12:29 ` Akhil R
2022-01-21 13:58 ` Andy Shevchenko
2022-01-20 13:44 ` [PATCH v3 2/3] docs: firmware-guide: ACPI: Add named interrupt doc Akhil R
2022-01-20 15:03 ` Andy Shevchenko [this message]
2022-01-21 12:50 ` Akhil R
2022-01-21 14:00 ` Andy Shevchenko
2022-01-21 14:09 ` Akhil R
2022-01-20 13:44 ` [PATCH v3 3/3] i2c: smbus: Use device_*() functions instead of of_*() Akhil R
2022-01-20 15:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VehSCxszDV3UQCEnPk7OCXRabRMJEStjpCamBG6X1iaCw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=christian.koenig@amd.com \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).