From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs Date: Tue, 2 Oct 2018 13:27:53 +0300 Message-ID: References: <20181001174349.26357-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Florian Fainelli , Linux Kernel Mailing List , Kamal Dasu , Geert Uytterhoeven , Wolfram Sang , Jarkko Nikula , Jean Delvare , kramasub@codeaurora.org, Manivannan Sadhasivam , Eddie James , James Hogan , Ard Biesheuvel , "Krogerus, Heikki" , linux-i2c List-Id: linux-i2c@vger.kernel.org On Tue, Oct 2, 2018 at 1:22 PM Arnd Bergmann wrote: > > On Mon, Oct 1, 2018 at 8:13 PM Andy Shevchenko > wrote: > > On Mon, Oct 1, 2018 at 8:44 PM Florian Fainelli wrote: > > > > > > config I2C_BRCMSTB > > > - tristate "BRCM Settop I2C controller" > > > - depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST > > > + tristate "BRCM Settop/DSL I2C controller" > > > + depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \ > > > + COMPILE_TEST > > > > I would rather split this to two 'depends' entries, though it's > > cosmetic and up to you. > > You can only split 'depends on A && B' into multiple lines, not > 'depends on A || B'. Indeed. What I was thinking of? -- With Best Regards, Andy Shevchenko