From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wolfram Sang <wsa@kernel.org>,
pierre-yves.mordret@st.com, alexandre.torgue@st.com,
linux-i2c@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
fabrice.gasnier@st.com, Krzysztof Kozlowski <krzk@kernel.org>,
Holger Assmann <h.assmann@pengutronix.de>
Subject: Re: [PATCH] i2c: stm32: do not display error when DMA is not requested
Date: Thu, 10 Sep 2020 15:35:34 +0200 [thread overview]
Message-ID: <CAJKOXPcx1tL93KJAvVT3rAgHX-r3bxri9GwHMSgDSAhALi2aFA@mail.gmail.com> (raw)
In-Reply-To: <20200910122739.GA5093@gnbcxd0016.gnb.st.com>
On Thu, 10 Sep 2020 at 14:27, Alain Volmat <alain.volmat@st.com> wrote:
>
> On Thu, Sep 10, 2020 at 12:06:07PM +0200, Wolfram Sang wrote:
> > On Thu, Sep 10, 2020 at 11:32:29AM +0200, Alain Volmat wrote:
> > > DMA usage is optional for the I2C driver. check for the -ENODEV
> > > error in order to avoid displaying an error when no DMA
> > > has been requested.
> > >
> > > Signed-off-by: Alain Volmat <alain.volmat@st.com>
> > > ---
> > > This patch should be applied on top of the patch [i2c: stm32: Simplify with dev_err_probe()]
> >
> > We can do it in this order, it just makes backporting to stable kernels
> > (if that is desired) a bit harder than a self-contained patch. I am fine
> > with both approaches, but just wanted to point it out.
>
> Indeed, that's a good point. I'll rework it then, to avoid the dependency
> on dev_err_probe change. If that is ok, I propose to push a two patches serie
> with both this fix (updated) followed by a rebased version of the
> dev_err_probe patch from Krzysztof for dev_err_probe change.
I can rebase mine on top of yours. Indeed such cleanups as mine should
be rather later in the queue.
Best regards,
Krzysztof
prev parent reply other threads:[~2020-09-10 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 9:32 [PATCH] i2c: stm32: do not display error when DMA is not requested Alain Volmat
2020-09-10 10:06 ` Wolfram Sang
2020-09-10 12:27 ` Alain Volmat
2020-09-10 12:50 ` Wolfram Sang
2020-09-10 13:35 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPcx1tL93KJAvVT3rAgHX-r3bxri9GwHMSgDSAhALi2aFA@mail.gmail.com \
--to=krzk@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=fabrice.gasnier@st.com \
--cc=h.assmann@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=pierre-yves.mordret@st.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).