From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7912DC4332F for ; Wed, 9 Feb 2022 16:15:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232353AbiBIQPr (ORCPT ); Wed, 9 Feb 2022 11:15:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230307AbiBIQPr (ORCPT ); Wed, 9 Feb 2022 11:15:47 -0500 X-Greylist: delayed 763 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 09 Feb 2022 08:15:48 PST Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DB00C0613C9; Wed, 9 Feb 2022 08:15:48 -0800 (PST) Received: from mail-wm1-f44.google.com ([209.85.128.44]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MZCOl-1nmGTJ08sz-00VAKE; Wed, 09 Feb 2022 17:03:04 +0100 Received: by mail-wm1-f44.google.com with SMTP id j5-20020a05600c1c0500b0034d2e956aadso1934394wms.4; Wed, 09 Feb 2022 08:03:03 -0800 (PST) X-Gm-Message-State: AOAM530akN/TDGCXa5H0nGdasan9Ro+71bb/LQDY1pnVcYUhawDwHwb9 gq6rLjysbFb+UNGjvsAnhAHnYvcYyLQaK9OqEeg= X-Google-Smtp-Source: ABdhPJxHAcHzTkMru4eEbqCHHWwDwZqYvTFbBt81TVOW87gLftYxW0tO+QQP3beMBCNrl8y6eFs1QMk5c63m/k04/W8= X-Received: by 2002:a1c:f309:: with SMTP id q9mr3200865wmq.173.1644422583536; Wed, 09 Feb 2022 08:03:03 -0800 (PST) MIME-Version: 1.0 References: <20211218165258.16716-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211218165258.16716-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <042a2183-3f04-088c-1861-656de870337d@gmail.com> <7c47ce67-88ee-9cba-3356-a530b0d3e657@gmail.com> In-Reply-To: <7c47ce67-88ee-9cba-3356-a530b0d3e657@gmail.com> From: Arnd Bergmann Date: Wed, 9 Feb 2022 17:02:47 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt To: Sergei Shtylyov Cc: Arnd Bergmann , Geert Uytterhoeven , Lad Prabhakar , Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Chris Brandt , Wolfram Sang , Linux I2C , linux-rpi-kernel , Linux ARM , Linux Kernel Mailing List , Linux-Renesas , Prabhakar , Linux-sh list Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:oOnrIzxPcdoamCYqgJO/oc+l7Sjc2zyhd85HLNkgXcpsHQkF/b5 RQh6FcYRuouqCm/fB4eenwPLcJvQbZTwxqZyA2xQ23XoSWQfp5eMgeAT9BO9Y7fiL2itSCJ i8k1NyxUoTjzMc7H8usXDRkXVBOPXWi53tNF5LopqmentlqSKiOr6vVxu9DM6CUoOdqOAUI eSQQ0eg3GmWVBtrz5tLYg== X-UI-Out-Filterresults: notjunk:1;V03:K0:zRg5TrnoYmQ=:TFD1uUkQxnj/tb9YU03Nq6 vkX8MQjrVHdrepckONzp1hySe00h1M8MFXQbq9zF6rjM/ycXPldgZzPd68/ic/2IxthVFUQZe tulZqiKbNXciHS+q80fCC+cRp8qe3S7FEt+jKcB7D3+cJ/9PeSq1uplTYt+onan6ELg3MGOuq m0NHngYvGn8rLVmfwB2tlNdJjzvR32iwnGZRW8difHtirsDEyDVHuOc+sAYcScONJsSVx1WvB IbGGlq5SCsUKiYi8u81L5ILepxrn3PagTpm1HDlWzt/sFMqIvRcVRIO0768Putm0vi3f24sZy MeDUDXekmpaoSrsWCjxNPKMmDcMbOy1pfB7wRbbvhgFxo1x0zClBC29zy0/EnPWB+5nihIf6I 9Mk/B+OSB6ss5DR81TCpC14LkBH9YZotehjmGngBCJiIkl5YppnwLb/oL6gtvY61uF0FpGZJb 1r3qFOVUpPssv7mdu11DmX06EfNSHqmpZGNWuVwxyWZPIwhPT+mbVRfeRv6j6Y1IEq8c9hrlq f1q9rQCv2JxCbxc2jBe/awshUqU80Yl2LUrPBm+oMMyryiTZgcrFnQPAZ6lkK0kfo7Md/5CCj Ru+PGF+6Y8Qpq+6lQzDxw5y5EL6pLDNIvcHuAzvLDfYjCnz/1n8siN9Jm7UcZoa+wygNqhOkj BK2Lt+niDzlYZy+xXGhrpD1HpL8DfylS/wIWBitgvI1rH47L0PCoKK7DAFc/gW+XoiF1eSLKk UVVyYL2YP3Oj1PhRvXvDP/xjkA+k1Z2CL/ewTVAsZ68g82udmTV3qXkB2TViDdqZDZBERAYKn Cjvloncv12/0NcWlEIo7UL5w2SdWSEMku+F3+k3UHLQtv5zDIQ= Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Wed, Feb 9, 2022 at 4:48 PM Sergei Shtylyov wrote: > On 2/9/22 6:18 PM, Arnd Bergmann wrote: > >>> since 2009 after 1e1030dccb10 ("sh: nmi_debug support."). On a > >> > >> Mhm... this commit changes the SH3 code while SH778x are SH4A, no? > > > > This code is shared between both: > > > > arch/sh/kernel/cpu/sh4/Makefile:common-y += $(addprefix > > ../sh3/, entry.o ex.o) > > Ah, quite convoluted! :-) > So you mean thet broke the delivery of EVT 0x200 when mucking with NMI? Yes, exactly: If I read this right, the added code: + shlr2 r4 + shlr r4 + mov r4, r0 ! save vector->jmp table offset for later + + shlr2 r4 ! vector to IRQ# conversion + add #-0x10, r4 + + cmp/pz r4 ! is it a valid IRQ? + bt 10f gets the vector (0x200 for this device), shifts it five bits to 0x10, and subtracts 0x10, then branches to do_IRQ if the interrupt number is non-zero, otherwise it goes through the exception_handling_table. Arnd