From: Arnd Bergmann <arnd@arndb.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kamal Dasu <kdasu.kdev@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
jarkko.nikula@linux.intel.com, Jean Delvare <jdelvare@suse.de>,
kramasub@codeaurora.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
eajames@linux.vnet.ibm.com, James Hogan <jhogan@kernel.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs
Date: Tue, 2 Oct 2018 12:22:24 +0200 [thread overview]
Message-ID: <CAK8P3a22COa4YyWc7_pCSAy3TU0mne76RGwG8d73Aphad_ekwg@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vd2js3QCJYjPDea5xapYLiOObSUF7_Q2hjG8RS=QYyPaQ@mail.gmail.com>
On Mon, Oct 1, 2018 at 8:13 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Oct 1, 2018 at 8:44 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
> >
> > config I2C_BRCMSTB
> > - tristate "BRCM Settop I2C controller"
> > - depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> > + tristate "BRCM Settop/DSL I2C controller"
> > + depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
> > + COMPILE_TEST
>
> I would rather split this to two 'depends' entries, though it's
> cosmetic and up to you.
You can only split 'depends on A && B' into multiple lines, not
'depends on A || B'.
Arnd
next prev parent reply other threads:[~2018-10-02 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 17:43 [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs Florian Fainelli
2018-10-01 18:13 ` Andy Shevchenko
2018-10-02 10:22 ` Arnd Bergmann [this message]
2018-10-02 10:27 ` Andy Shevchenko
2018-10-05 12:07 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a22COa4YyWc7_pCSAy3TU0mne76RGwG8d73Aphad_ekwg@mail.gmail.com \
--to=arnd@arndb.de \
--cc=andy.shevchenko@gmail.com \
--cc=ard.biesheuvel@linaro.org \
--cc=eajames@linux.vnet.ibm.com \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=jhogan@kernel.org \
--cc=kdasu.kdev@gmail.com \
--cc=kramasub@codeaurora.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).