* [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs
@ 2018-10-01 17:43 Florian Fainelli
2018-10-01 18:13 ` Andy Shevchenko
2018-10-05 12:07 ` Wolfram Sang
0 siblings, 2 replies; 5+ messages in thread
From: Florian Fainelli @ 2018-10-01 17:43 UTC (permalink / raw)
To: linux-kernel
Cc: kdasu.kdev, geert, Florian Fainelli, Wolfram Sang, Jarkko Nikula,
Jean Delvare, Andy Shevchenko, Karthikeyan Ramasubramanian,
Manivannan Sadhasivam, Eddie James, James Hogan, Arnd Bergmann,
Ard Biesheuvel, Heikki Krogerus,
open list:I2C SUBSYSTEM HOST DRIVERS
ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses the
same controller, make it possible to select the STB driver and update
the Kconfig and help text a bit.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:
- Make COMPILE_TEST last, as per Geert's recommendation
drivers/i2c/busses/Kconfig | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 451d4ae50e66..56ccb1ea7da5 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -432,12 +432,13 @@ config I2C_BCM_KONA
If you do not need KONA I2C interface, say N.
config I2C_BRCMSTB
- tristate "BRCM Settop I2C controller"
- depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
+ tristate "BRCM Settop/DSL I2C controller"
+ depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
+ COMPILE_TEST
default y
help
If you say yes to this option, support will be included for the
- I2C interface on the Broadcom Settop SoCs.
+ I2C interface on the Broadcom Settop/DSL SoCs.
If you do not need I2C interface, say N.
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs
2018-10-01 17:43 [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs Florian Fainelli
@ 2018-10-01 18:13 ` Andy Shevchenko
2018-10-02 10:22 ` Arnd Bergmann
2018-10-05 12:07 ` Wolfram Sang
1 sibling, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2018-10-01 18:13 UTC (permalink / raw)
To: Florian Fainelli
Cc: Linux Kernel Mailing List, Kamal Dasu, Geert Uytterhoeven,
Wolfram Sang, Jarkko Nikula, Jean Delvare, kramasub,
Manivannan Sadhasivam, Eddie James, James Hogan, Arnd Bergmann,
Ard Biesheuvel, Krogerus, Heikki, linux-i2c
On Mon, Oct 1, 2018 at 8:44 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses the
> same controller, make it possible to select the STB driver and update
> the Kconfig and help text a bit.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes in v2:
>
> - Make COMPILE_TEST last, as per Geert's recommendation
>
> drivers/i2c/busses/Kconfig | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 451d4ae50e66..56ccb1ea7da5 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -432,12 +432,13 @@ config I2C_BCM_KONA
> If you do not need KONA I2C interface, say N.
>
> config I2C_BRCMSTB
> - tristate "BRCM Settop I2C controller"
> - depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> + tristate "BRCM Settop/DSL I2C controller"
> + depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
> + COMPILE_TEST
I would rather split this to two 'depends' entries, though it's
cosmetic and up to you.
> default y
> help
> If you say yes to this option, support will be included for the
> - I2C interface on the Broadcom Settop SoCs.
> + I2C interface on the Broadcom Settop/DSL SoCs.
>
> If you do not need I2C interface, say N.
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs
2018-10-01 18:13 ` Andy Shevchenko
@ 2018-10-02 10:22 ` Arnd Bergmann
2018-10-02 10:27 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2018-10-02 10:22 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Florian Fainelli, Linux Kernel Mailing List, Kamal Dasu,
Geert Uytterhoeven, Wolfram Sang, jarkko.nikula, Jean Delvare,
kramasub, Manivannan Sadhasivam, eajames, James Hogan,
Ard Biesheuvel, Heikki Krogerus, Linux I2C
On Mon, Oct 1, 2018 at 8:13 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Oct 1, 2018 at 8:44 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
> >
> > config I2C_BRCMSTB
> > - tristate "BRCM Settop I2C controller"
> > - depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> > + tristate "BRCM Settop/DSL I2C controller"
> > + depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
> > + COMPILE_TEST
>
> I would rather split this to two 'depends' entries, though it's
> cosmetic and up to you.
You can only split 'depends on A && B' into multiple lines, not
'depends on A || B'.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs
2018-10-02 10:22 ` Arnd Bergmann
@ 2018-10-02 10:27 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2018-10-02 10:27 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Florian Fainelli, Linux Kernel Mailing List, Kamal Dasu,
Geert Uytterhoeven, Wolfram Sang, Jarkko Nikula, Jean Delvare,
kramasub, Manivannan Sadhasivam, Eddie James, James Hogan,
Ard Biesheuvel, Krogerus, Heikki, linux-i2c
On Tue, Oct 2, 2018 at 1:22 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Mon, Oct 1, 2018 at 8:13 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Mon, Oct 1, 2018 at 8:44 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
> > >
> > > config I2C_BRCMSTB
> > > - tristate "BRCM Settop I2C controller"
> > > - depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> > > + tristate "BRCM Settop/DSL I2C controller"
> > > + depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
> > > + COMPILE_TEST
> >
> > I would rather split this to two 'depends' entries, though it's
> > cosmetic and up to you.
>
> You can only split 'depends on A && B' into multiple lines, not
> 'depends on A || B'.
Indeed. What I was thinking of?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs
2018-10-01 17:43 [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs Florian Fainelli
2018-10-01 18:13 ` Andy Shevchenko
@ 2018-10-05 12:07 ` Wolfram Sang
1 sibling, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2018-10-05 12:07 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-kernel, kdasu.kdev, geert, Wolfram Sang, Jarkko Nikula,
Jean Delvare, Andy Shevchenko, Karthikeyan Ramasubramanian,
Manivannan Sadhasivam, Eddie James, James Hogan, Arnd Bergmann,
Ard Biesheuvel, Heikki Krogerus,
open list:I2C SUBSYSTEM HOST DRIVERS
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
On Mon, Oct 01, 2018 at 10:43:47AM -0700, Florian Fainelli wrote:
> ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses the
> same controller, make it possible to select the STB driver and update
> the Kconfig and help text a bit.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes in v2:
>
> - Make COMPILE_TEST last, as per Geert's recommendation
>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-05 12:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-01 17:43 [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs Florian Fainelli
2018-10-01 18:13 ` Andy Shevchenko
2018-10-02 10:22 ` Arnd Bergmann
2018-10-02 10:27 ` Andy Shevchenko
2018-10-05 12:07 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).