From: Arnd Bergmann <arnd@arndb.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] misc: apds990x: move header file out of I2C realm
Date: Mon, 22 May 2017 16:29:31 +0200 [thread overview]
Message-ID: <CAK8P3a2CfOPNe5KnSWb=xf_0YTtN6aQRwNthQXEDb9YgOrLMaw@mail.gmail.com> (raw)
In-Reply-To: <20170521204233.6745-2-wsa@the-dreams.de>
On Sun, May 21, 2017 at 10:42 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> drivers/misc/apds990x.c | 2 +-
> include/linux/{i2c => platform_data}/apds990x.h | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename include/linux/{i2c => platform_data}/apds990x.h (100%)
>
> diff --git a/drivers/misc/apds990x.c b/drivers/misc/apds990x.c
> index dfb72ecfa60461..c341164edaad01 100644
> --- a/drivers/misc/apds990x.c
> +++ b/drivers/misc/apds990x.c
> @@ -32,7 +32,7 @@
> #include <linux/delay.h>
> #include <linux/wait.h>
> #include <linux/slab.h>
> -#include <linux/i2c/apds990x.h>
> +#include <linux/platform_data/apds990x.h>
The new location is clearly better than the old, but I notice that in both
patches, there is not a single definition for the platform_data structure
in the kernel and both drivers refuse to load when they do not get
passed valid platform_data.
Should we also remove the drivers or move them into staging?
Arnd
next prev parent reply other threads:[~2017-05-22 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 20:42 [PATCH 0/2] misc: move include files out of include/linux/i2c Wolfram Sang
2017-05-21 20:42 ` [PATCH 1/2] misc: apds990x: move header file out of I2C realm Wolfram Sang
2017-05-22 14:29 ` Arnd Bergmann [this message]
2017-05-22 15:56 ` Wolfram Sang
2017-05-22 21:49 ` Arnd Bergmann
2017-05-22 22:33 ` Linus Walleij
2017-05-25 23:22 ` Wolfram Sang
2017-05-23 6:23 ` Wolfram Sang
2017-05-21 20:42 ` [PATCH 2/2] misc: bh1770glc: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a2CfOPNe5KnSWb=xf_0YTtN6aQRwNthQXEDb9YgOrLMaw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).