From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, Jochen Friedrich <jochen@scram.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH v2] ARM: sa1100: simpad: Correct I2C GPIO offsets
Date: Fri, 10 Nov 2017 16:17:26 +0100 [thread overview]
Message-ID: <CAK8P3a3s-1mD+eVagHBr-YL-nAyr_QN2VZNo7qBn=FZCQfEEkg@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdangY192aFpSd1hVaie6A8kY+sASORhR_ncHLYLeUJMWw@mail.gmail.com>
On Fri, Nov 10, 2017 at 4:01 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Nov 10, 2017 at 3:50 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> Applied to for-next, thanks!
>
> Thanks man.
>
>> This from checkpatch makes sense to me:
>>
>> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit b2e63555592f ("i2c: gpio: Convert to use descriptors")'
>> #21:
>> commit b2e63555592f81331c8da3afaa607d8cf83e8138
>
> I never understood that thingie, I thought the check was
> only there in order to stop Fixes: tags from running wild.
> But feel free to cut it if you want.
I have this in my ~/.gitconfig:
[core]
abbrev = 12
[alias]
fixes = show --format='Fixes: %h (\"%s\")' -s
So 'git fixes b2e63555592f81331c8da3afaa607d8cf83e8138' produces
Fixes: b2e63555592f ("i2c: gpio: Convert to use descriptors")
which I then copy into a changelog as the last line, or use only the reference.
Arnd
next prev parent reply other threads:[~2017-11-10 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 20:18 [PATCH v2] ARM: sa1100: simpad: Correct I2C GPIO offsets Linus Walleij
2017-11-07 20:36 ` Wolfram Sang
2017-11-08 10:54 ` Arnd Bergmann
2017-11-08 10:55 ` Arnd Bergmann
2017-11-10 14:50 ` Wolfram Sang
2017-11-10 15:01 ` Linus Walleij
2017-11-10 15:17 ` Arnd Bergmann [this message]
2017-11-24 10:04 ` Linus Walleij
2017-11-24 12:36 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3s-1mD+eVagHBr-YL-nAyr_QN2VZNo7qBn=FZCQfEEkg@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=jochen@scram.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).