From: Shubhrajyoti Datta <shubhrajyoti.datta@gmail.com>
To: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
Cc: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
linux-i2c@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
anirudh@xilinx.com, Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Shubhrajyoti Datta <shubhraj@xilinx.com>
Subject: Re: [PATCH v2] i2c: cadence: Move to sensible power management
Date: Tue, 24 Nov 2015 09:58:32 +0530 [thread overview]
Message-ID: <CAKfKVtHbzEAWL8OedkxY2bfC+oR_DHejS3Lx5F_t0mKCs21i2g@mail.gmail.com> (raw)
In-Reply-To: <20151123184710.GH32017@xsjsorenbubuntu>
On Tue, Nov 24, 2015 at 12:17 AM, Sören Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> On Sat, 2015-11-21 at 07:00PM +0530, Shubhrajyoti Datta wrote:
>> On Thu, Oct 29, 2015 at 8:27 PM, Shubhrajyoti Datta
>> <shubhrajyoti.datta@gmail.com> wrote:
>> > On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann
>> > <soren.brinkmann@xilinx.com> wrote:
>> >> Hi Shubhrajyoti,
>> >>
>> >>
>> >> On Wed, 2015-10-28 at 12:56PM +0530, Shubhrajyoti Datta wrote:
>> >>> Currently the clocks are enabled at probe and disabled at remove.
>> >>> Which keeps the clocks enabled even if no transaction is going on.
>> >>> This patch enables the clocks at the start of transfer and disables
>> >>> after it.
>> >>>
>> >>> Also adapts to runtime pm.
>> >>> Remove xi2c->suspended and use pm runtime status instead.
>> >>>
>> >>> converts dev pm to const to silence a checkpatch warning.
>> >>>
>> >>> Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com>
>> >>
>> >> To me, this looks all good. Just one small concern below.
>> >
>> > Thanks for the review.
>> Soren ,
>> Do are you ok with the change or do you want me to resend without the
>> suspended flag change.
>
> I'm always for removing code that is not needed. If things are tested
> and well and work without throwing any warnings I'm OK with it.
It should be also having a suspended book-keeping in the driver is not
needed the pm does that for us.
I will spilt the patch and resend.
Thanks,
>
> Sören
prev parent reply other threads:[~2015-11-24 4:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 7:26 [PATCH v2] i2c: cadence: Move to sensible power management Shubhrajyoti Datta
2015-10-28 16:18 ` Sören Brinkmann
2015-10-29 14:57 ` Shubhrajyoti Datta
2015-11-21 13:30 ` Shubhrajyoti Datta
2015-11-23 18:47 ` Sören Brinkmann
2015-11-24 4:28 ` Shubhrajyoti Datta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKfKVtHbzEAWL8OedkxY2bfC+oR_DHejS3Lx5F_t0mKCs21i2g@mail.gmail.com \
--to=shubhrajyoti.datta@gmail.com \
--cc=anirudh@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhraj@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).