From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ard Biesheuvel Subject: Re: [PATCH v6 0/3] add support for Socionext SynQuacer I2C controller Date: Tue, 3 Apr 2018 20:05:53 +0200 Message-ID: References: <20180325110747.8852-1-ard.biesheuvel@linaro.org> <20180403150139.l7oec4doafmsidfp@ninjato> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180403150139.l7oec4doafmsidfp@ninjato> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Wolfram Sang Cc: Andy Shevchenko , Jassi Brar , linux-i2c , linux-arm-kernel List-Id: linux-i2c@vger.kernel.org On 3 April 2018 at 17:01, Wolfram Sang wrote: > >> - switch to generic recovery using minimal helpers to drive the SDA/SCL lines >> directly > > If you had added this incrementally, reviewing would have been easier (= > faster). The callbacks look okay... > >> - don't recover on every error > > ... but you are now never recovering. You don't call i2c_recover_bus(). > Yeah, good point. So when exactly should this be called? Only on error conditions that could be caused by a misbehaving slave? >> - add patch to sanity check i2c_transfer() arguments in core code (#3) > > See small comment there. >