linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume
@ 2012-10-10 12:18 Kalle Jokiniemi
       [not found] ` <1349871480-25182-1-git-send-email-kalle.jokiniemi-4y2FMlU5MS8onNqTyK5kxQ@public.gmane.org>
  0 siblings, 1 reply; 21+ messages in thread
From: Kalle Jokiniemi @ 2012-10-10 12:18 UTC (permalink / raw)
  To: linux-i2c, w.sang, ben-linux
  Cc: tony, linux-omap, grygorii.strashko, khilman, shubhrajyoti,
	Kalle Jokiniemi

The resume_noirq enables interrupts one-by-one starting from
first one. Now if the wake up event for suspend came from i2c
device, the i2c bus irq gets enabled before the threaded
i2c device irq, causing a flood of i2c bus interrupts as the
threaded irq that should clear the event is not enabled yet.

Fixed the issue by adding suspend_noirq and resume_early
functions that keep i2c bus interrupts disabled until
resume_noirq has run completely.

Issue was detected doing a wake up from autosleep with
twl4030 power key on N9. Patch tested on N9.

Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
---
 drivers/i2c/busses/i2c-omap.c |   34 ++++++++++++++++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index a0e49f6..991341b 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1132,6 +1132,36 @@ static int __devexit omap_i2c_remove(struct platform_device *pdev)
 }
 
 #ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
+static int omap_i2c_suspend_noirq(struct device *dev)
+{
+
+	struct platform_device *pdev = to_platform_device(dev);
+	struct omap_i2c_dev *_dev = platform_get_drvdata(pdev);
+
+	/* Disabling irq here to balance the enable in resume_early */
+	disable_irq(_dev->irq);
+	return 0;
+}
+
+static int omap_i2c_resume_early(struct device *dev)
+{
+
+	struct platform_device *pdev = to_platform_device(dev);
+	struct omap_i2c_dev *_dev = platform_get_drvdata(pdev);
+
+	/*
+	 * The noirq_resume enables the interrupts one by one,
+	 * this causes a interrupt flood if the SW irq actually reading
+	 * event from i2c device is enabled only after i2c bus irq, as the
+	 * irq that should clear the event is still disabled. We have to
+	 * keep the bus irq disabled until all other irqs have been enabled.
+	 */
+	enable_irq(_dev->irq);
+
+	return 0;
+}
+#endif
 #ifdef CONFIG_PM_RUNTIME
 static int omap_i2c_runtime_suspend(struct device *dev)
 {
@@ -1183,6 +1213,10 @@ static int omap_i2c_runtime_resume(struct device *dev)
 #endif /* CONFIG_PM_RUNTIME */
 
 static struct dev_pm_ops omap_i2c_pm_ops = {
+#ifdef CONFIG_PM_SLEEP
+	.suspend_noirq = omap_i2c_suspend_noirq,
+	.resume_early = omap_i2c_resume_early,
+#endif
 	SET_RUNTIME_PM_OPS(omap_i2c_runtime_suspend,
 			   omap_i2c_runtime_resume, NULL)
 };
-- 
1.7.4.1


^ permalink raw reply related	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2012-10-18  7:11 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-10 12:18 [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume Kalle Jokiniemi
     [not found] ` <1349871480-25182-1-git-send-email-kalle.jokiniemi-4y2FMlU5MS8onNqTyK5kxQ@public.gmane.org>
2012-10-11  7:59   ` Shubhrajyoti Datta
2012-10-11 21:08   ` Kevin Hilman
     [not found]     ` <87ipag90om.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2012-10-12 10:18       ` Strashko, Grygorii
2012-10-12 11:33         ` Shubhrajyoti
     [not found]           ` <5077FFEC.5040407-l0cyMroinI0@public.gmane.org>
2012-10-12 12:55             ` Kankroliwala, Huzefa
2012-10-12 13:28         ` Kalle Jokiniemi
     [not found]         ` <902E09E6452B0E43903E4F2D568737AB2C87B0-bXo5r3zvlxeIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2012-10-12 14:17           ` Kevin Hilman
2012-10-12 14:34         ` Kevin Hilman
     [not found]           ` <87d30n7o9q.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2012-10-12 14:46             ` Strashko, Grygorii
2012-10-12 16:43               ` Kevin Hilman
     [not found]                 ` <87r4p363ps.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2012-10-12 18:11                   ` Shubhrajyoti Datta
2012-10-12 19:04                     ` Kevin Hilman
     [not found]                       ` <87txtzy0jf.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2012-10-12 19:15                         ` shubhro
     [not found]               ` <902E09E6452B0E43903E4F2D568737AB2C8C9F-bXo5r3zvlxeIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2012-10-15  6:21                 ` Kalle Jokiniemi
2012-10-15  9:16                   ` Kalle Jokiniemi
2012-10-15 10:11                     ` Shubhrajyoti Datta
     [not found]                       ` <CAM=Q2cuJ-0VSgkBme_Cg8YD2cBG5NZcO6aBeTsPZ_PQGMwJ=bw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-15 14:10                         ` Kalle Jokiniemi
2012-10-17 16:02       ` Felipe Balbi
     [not found]         ` <20121017160200.GA6567-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-10-18  6:51           ` Kalle Jokiniemi
2012-10-18  7:11             ` Felipe Balbi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).