From: Shubhrajyoti Datta <omaplinuxkernel@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
khali@linux-fr.org, w.sang@pengutronix.de,
linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 3/3] i2c-s3c2410: Refactor ifdefs for PM_SLEEP
Date: Fri, 17 Feb 2012 17:49:40 +0530 [thread overview]
Message-ID: <CAM=Q2cuo3BPK3ZEm-ad_0k_tOsiB3rc=sRjdrKgYu7UGCy1yoQ@mail.gmail.com> (raw)
In-Reply-To: <1329174304-12228-3-git-send-email-broonie@opensource.wolfsonmicro.com>
On Tue, Feb 14, 2012 at 4:35 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> Use the PM_SLEEP ifdef for system suspend and resume. This is partly
> in preparation for adding runtime operations and partly because a user
> may in theory choose to enable runtime suspend but not system suspend.
>
Yes also rand defconfig may see some warns.
Looks good to me
Reviewed-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/i2c/busses/i2c-s3c2410.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 1cb06c58..5d8e802 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1073,7 +1073,7 @@ static int s3c24xx_i2c_remove(struct platform_device *pdev)
> return 0;
> }
>
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
> static int s3c24xx_i2c_suspend_noirq(struct device *dev)
> {
> struct platform_device *pdev = to_platform_device(dev);
> @@ -1096,10 +1096,14 @@ static int s3c24xx_i2c_resume(struct device *dev)
>
> return 0;
> }
> +#endif
>
> +#ifdef CONFIG_PM
> static const struct dev_pm_ops s3c24xx_i2c_dev_pm_ops = {
> +#ifdef CONFIG_PM_SLEEP
> .suspend_noirq = s3c24xx_i2c_suspend_noirq,
> .resume = s3c24xx_i2c_resume,
> +#endif
> };
>
> #define S3C24XX_DEV_PM_OPS (&s3c24xx_i2c_dev_pm_ops)
> --
> 1.7.9.rc1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-02-17 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 23:05 [PATCH 1/3] i2c-s3c2410: Convert to devm_kzalloc() Mark Brown
2012-02-13 23:05 ` [PATCH 2/3] i2c-s3c2410: Add stub runtime power management Mark Brown
2012-02-13 23:05 ` [PATCH 3/3] i2c-s3c2410: Refactor ifdefs for PM_SLEEP Mark Brown
2012-02-17 12:19 ` Shubhrajyoti Datta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM=Q2cuo3BPK3ZEm-ad_0k_tOsiB3rc=sRjdrKgYu7UGCy1yoQ@mail.gmail.com' \
--to=omaplinuxkernel@gmail.com \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).