From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartosz Golaszewski Subject: Re: [PATCH 04/21] eeprom: at24: use SPDX identifier instead of GPL boiler-plate Date: Mon, 19 Mar 2018 13:12:51 +0100 Message-ID: References: <20180319091721.18193-1-brgl@bgdev.pl> <20180319091721.18193-5-brgl@bgdev.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Peter Rosin Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-i2c , Linux Kernel Mailing List List-Id: linux-i2c@vger.kernel.org 2018-03-19 12:03 GMT+01:00 Peter Rosin : > On 2018-03-19 10:17, Bartosz Golaszewski wrote: >> Replace the GPL header with an SPDX identifier for GPL-2.0. > > Great care should be exercised when dealing with copyrights of others. > >> >> Signed-off-by: Bartosz Golaszewski >> --- >> drivers/misc/eeprom/at24.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c >> index 2a4154eeb1bd..0e06201d33c9 100644 >> --- a/drivers/misc/eeprom/at24.c >> +++ b/drivers/misc/eeprom/at24.c >> @@ -1,14 +1,11 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ > > This should be 2.0+ Indeed, thanks. > > Also, use a // style comment for the SPDX line in C files. > > Cheers, > Peter I'm seeing both /* */ and // style comments used for SPDX headers - is there any reason not to use /* */ here? Bart