From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Am=C3=A9rico_Wang?= Subject: Re: [PATCH] i2c: remove deprecated callbacks Date: Thu, 1 Sep 2011 17:12:00 +0800 Message-ID: References: <1314852027-9523-1-git-send-email-xiyou.wangcong@gmail.com> <20110901105226.0d8dd8b2@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20110901105226.0d8dd8b2@endymion.delvare> Sender: linux-doc-owner@vger.kernel.org To: Jean Delvare Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Randy Dunlap , Ben Dooks , linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org, Benjamin Herrenschmidt List-Id: linux-i2c@vger.kernel.org On Thu, Sep 1, 2011 at 4:52 PM, Jean Delvare wrote= : > Hi Cong, > > On Thu, =C2=A01 Sep 2011 12:40:27 +0800, WANG Cong wrote: >> i2c_driver.attach_adapter and i2c_driver.detach_adapter are deprecat= ed >> and scheduled to be removed in Sep 2011. >> >> Cc: Jean Delvare >> Signed-off-by: WANG Cong > > I'm not sure what you are trying to achieve here. I just want to make feature-removal-schedule.txt working. :) > > I am obviously aware of these functions being deprecated, I am the on= e > who added the entry in feature-removal-schedule.txt. And as a matter = of > fact, I have a patch ready for months now. > > I could understand you sending a patch if the entry had expired long > ago, but this isn't the case: it is marked for September 2011 and you > send a patch on September 1st. Hardly a coincidence. While there > certainly is a benefit in people reading feature-removal-schedule.txt > and trying to clean it up by closing old (presumably forgotten) > entries, this doesn't apply here. > > Furthermore, you didn't even check if the deprecated callbacks were > still in use. It turns out that there are 9 drivers still using one o= f > them (6 macintosh drivers and 3 sound drivers) so plain removing it > will cause build breakages. We obviously don't want to do that, so I = am > not going to apply your patch (nor mine) for now. Hmm, sorry that I didn't know this, maybe we can defer the removal of these callbacks? > > I know that Benjamin Herrenschmidt is working on converting (some of) > the macintosh drivers. I don't have any news for some time though. Be= n, > are you done with the conversion by now? It would be great to get it > merged in kernel 3.2. > > Cong, do you have a specific interest in these callbacks being remove= d? > > If you want to help, then instead of sending a patch which I already > have and virtually everybody could have written, please get the > remaining 3 drivers converted to the current i2c binding model: > =C2=A0sound/ppc/keywest.c > =C2=A0sound/aoa/codecs/onyx.c > =C2=A0sound/aoa/codecs/tas.c Sure, if I can... so how do we convert them? Any examples? Thanks!