From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c <linux-i2c@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read
Date: Wed, 21 Oct 2015 16:42:04 +0200 [thread overview]
Message-ID: <CAMpxmJWkioHCLZnJ7LfK3Y4K4jJ2iPMaZ4Kaj_BmAwXqYfW76A@mail.gmail.com> (raw)
In-Reply-To: <87oafsti5k.fsf@dell.be.48ers.dk>
2015-10-21 16:23 GMT+02:00 Peter Korsgaard <peter@korsgaard.com>:
>>>>>> "Bartosz" == Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
>
> >> As the serial number is available on a separate i2c address, wouldn't
> >> it be simpler to handle these as special (read only) device variants and
> >> instantiate E.G. a 24c64 (for the normal data) and a 24cs64 (for the
> >> serial)?
> >>
>
> > Hi Peter,
>
> > I wanted to respond that this way we would not be protected from
> > concurrent accesses, but then I saw I didn't actually include any
> > locks in the serial read function - my bad. It needs to be fixed as
> > both memory blocks share the same address pointer.
>
> > I'll resend the series.
>
> But we're protected by the i2c bus lock, right? You do a single
> i2c_transfer to read the serial number.
Why the at24->lock then?
Best regards,
Bartosz Golaszewski
next prev parent reply other threads:[~2015-10-21 14:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 8:43 [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 1/9] eeprom: at24: platform_data: use BIT() macro Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 2/9] eeprom: at24: new flag in platform_data Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 3/9] eeprom: at24: tie up an additional address for at24cs series Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 4/9] eeprom: at24: support reading of the serial number Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 5/9] eeprom: at24: export the serial number through sysfs Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 6/9] eeprom: at24: improve the device_id table readability Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 7/9] eeprom: at24: add the at24cs series to the list of supported devices Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 8/9] eeprom: at24: remove a reduntant if Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 9/9] eeprom: at24: readability tweaks Bartosz Golaszewski
2015-10-21 11:03 ` [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read Peter Korsgaard
2015-10-21 14:15 ` Bartosz Golaszewski
2015-10-21 14:23 ` Peter Korsgaard
2015-10-21 14:42 ` Bartosz Golaszewski [this message]
2015-10-21 15:08 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJWkioHCLZnJ7LfK3Y4K4jJ2iPMaZ4Kaj_BmAwXqYfW76A@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@korsgaard.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).