linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Ulrich Hecht <uli+renesas@fpond.eu>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c: sh_mobile: implement atomic transfers
Date: Mon, 15 Jun 2020 14:57:44 +0200	[thread overview]
Message-ID: <CAMuHMdVjJTjuswQYkTfWs1oxA676rEQW5TRy35XFecGpeLrrCA@mail.gmail.com> (raw)
In-Reply-To: <20200615125015.GC4423@kunai>

Hi Wolfram,

On Mon, Jun 15, 2020 at 2:50 PM Wolfram Sang <wsa@the-dreams.de> wrote:
> > After removing the first hunk, this works fine on r8a7791/koelsch.
>
> Removing the first hunk? This one?
>
> +       bool atomic_xfer;

Oops, no.  I hadn't looked that close at the numbers, and assumed the failure
was about the first hunk:

Hunk #3 FAILED at 369.
Hunk #4 succeeded at 432 (offset -3 lines).
Hunk #5 succeeded at 585 (offset -3 lines).
Hunk #6 succeeded at 643 (offset -3 lines).
Hunk #7 succeeded at 666 (offset -3 lines).
Hunk #8 succeeded at 717 (offset -3 lines).
1 out of 8 hunks FAILED -- saving rejects to file
drivers/i2c/busses/i2c-sh_mobile.c.rej

I meant the one with the "data" var.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2020-06-15 12:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 19:33 [PATCH] i2c: sh_mobile: implement atomic transfers Ulrich Hecht
2020-06-14  9:31 ` Wolfram Sang
2020-06-15 10:01   ` Geert Uytterhoeven
2020-06-15 12:48     ` Wolfram Sang
2020-06-15 12:58       ` Geert Uytterhoeven
2020-06-15 13:12         ` Wolfram Sang
2020-06-18  9:53   ` Ulrich Hecht
2020-06-15  9:41 ` Geert Uytterhoeven
2020-06-15 12:50   ` Wolfram Sang
2020-06-15 12:57     ` Geert Uytterhoeven [this message]
2020-06-15 13:08       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdVjJTjuswQYkTfWs1oxA676rEQW5TRy35XFecGpeLrrCA@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=uli+renesas@fpond.eu \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).