From: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux-sh list <linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/5] i2c: sh_mobile: add DMA support
Date: Mon, 15 Dec 2014 10:32:00 +0100 [thread overview]
Message-ID: <CAMuHMdWCdvnUAsZOYNfmzat5wfPnaKf1H4mupg0L0mLLKuwqQA@mail.gmail.com> (raw)
In-Reply-To: <20141215090628.GB1031@katana>
Hi Wolfram,
On Mon, Dec 15, 2014 at 10:06 AM, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
>> Solutions under consideration:
>> 1. Wolfram posted a patch to make i2c-sh_mobile fall back to PIO,
>> and retry DMA initialization in every request, so it will switch to
>> DMA when it becomes available. But this is suboptimal, as it adds
>> overhead to every request (and DMA may never become available in
>> case 2).
>
> Still, I'd think I should repost my patches with your comments
> addressed. It does add a bit of overhead IF the dmaengine core is
> compiled in AND the driver for the DMA hardware is not. Well, yeah. On
> the other hand, it fixes the regression that the driver is not even
> loaded in that case (because it currently will be deferred endlessly).
>
> What do you think?
I think it doesn't hurt to repost, now more people understand the intrinsics
of the problem.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2014-12-15 9:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 10:11 [PATCH 0/5] i2c: sh_mobile: add DMA support Wolfram Sang
2014-11-07 10:11 ` [PATCH 1/5] i2c: sh_mobile: sort includes alphabetically Wolfram Sang
2014-11-12 16:10 ` Wolfram Sang
2014-11-07 10:11 ` [PATCH 2/5] i2c: sh_mobile: add DMA support Wolfram Sang
2014-11-12 16:11 ` Wolfram Sang
2014-12-09 10:53 ` Geert Uytterhoeven
2014-12-09 14:09 ` Wolfram Sang
2014-12-10 5:44 ` Magnus Damm
2014-12-10 8:01 ` Wolfram Sang
2014-12-10 14:19 ` Laurent Pinchart
2014-12-10 14:23 ` Wolfram Sang
2014-12-11 5:02 ` Vinod Koul
2014-12-11 7:37 ` Wolfram Sang
2014-12-11 7:47 ` Laurent Pinchart
2014-12-11 8:28 ` Wolfram Sang
2014-12-11 21:42 ` Laurent Pinchart
2014-12-11 21:47 ` Wolfram Sang
2014-12-11 21:52 ` Laurent Pinchart
2014-12-12 11:07 ` Wolfram Sang
2014-12-15 6:43 ` Vinod Koul
2014-12-15 8:31 ` Geert Uytterhoeven
2014-12-15 9:06 ` Wolfram Sang
2014-12-15 9:32 ` Geert Uytterhoeven [this message]
2014-12-15 9:13 ` Vinod Koul
[not found] ` <20141215091314.GQ16827-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-15 9:42 ` Laurent Pinchart
2014-12-15 14:48 ` Vinod Koul
2014-12-15 9:45 ` Wolfram Sang
2014-12-15 14:50 ` Vinod Koul
2014-11-07 10:11 ` [PATCH 3/5] i2c: sh_mobile: improve success message Wolfram Sang
2014-11-12 16:12 ` Wolfram Sang
2014-11-13 0:27 ` Simon Horman
2014-11-07 10:11 ` [PATCH 4/5] ARM: shmobile: r8a7790: add DMA nodes for IIC Wolfram Sang
2014-11-13 0:26 ` Simon Horman
2014-11-07 10:11 ` [PATCH 5/5] ARM: shmobile: r8a7791: " Wolfram Sang
2014-11-13 0:26 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWCdvnUAsZOYNfmzat5wfPnaKf1H4mupg0L0mLLKuwqQA@mail.gmail.com \
--to=geert-td1emuhucqxl1znqvxdv9g@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).