From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Phil Edworthy <phil.edworthy@renesas.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Wolfram Sang <wsa@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Sam Protsenko <semen.protsenko@linaro.org>,
Rob Herring <robh@kernel.org>, Sven Peter <sven@svenpeter.dev>,
Jie Deng <jie.deng@intel.com>, Jan Dabros <jsd@semihalf.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Tyrone Ting <kfting@nuvoton.com>, Olof Johansson <olof@lixom.net>,
Biju Das <biju.das.jz@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux I2C <linux-i2c@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 2/2] i2c: Add Renesas RZ/V2M controller
Date: Fri, 24 Jun 2022 13:48:58 +0200 [thread overview]
Message-ID: <CAMuHMdWNvFARZgM1QX_t9aq1Kh84i2aCxcG5k9LqDM=wQu15pw@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a085ZuyTXAWupo56wwfKdkM9EFnkPHXzxTxwTUUR5ee9Q@mail.gmail.com>
Hi Arnd,
On Fri, Jun 24, 2022 at 1:27 PM Arnd Bergmann <arnd@arndb.de> wrote:
> On Fri, Jun 24, 2022 at 12:17 PM Phil Edworthy
> <phil.edworthy@renesas.com> wrote:
> >
> > Yet another i2c controller from Renesas that is found on the RZ/V2M
> > (r9a09g011) SoC. It can support only 100kHz and 400KHz operation.
>
> I see nothing wrong with this, just one suggestion for a cleanup:
>
> > +#ifdef CONFIG_PM_SLEEP
> > +static int rzv2m_i2c_suspend(struct device *dev)
> ...> +static const struct dev_pm_ops rzv2m_i2c_pm_ops = {
> > + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(rzv2m_i2c_suspend, rzv2m_i2c_resume)
> > +};
> > +
> > +#define DEV_PM_OPS (&rzv2m_i2c_pm_ops)
> > +#else
> > +#define DEV_PM_OPS NULL
> > +#endif /* CONFIG_PM_SLEEP */
>
> Remove the #ifdef here, and use the new NOIRQ_SYSTEM_SLEEP_PM_OPS()
> in place of SET_NOIRQ_SYSTEM_SLEEP_PM_OPS().
Cool, TIL!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2022-06-24 11:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 10:17 [PATCH 0/2] i2c: Add new driver for Renesas RZ/V2M controller Phil Edworthy
2022-06-24 10:17 ` [PATCH 1/2] dt-bindings: i2c: Document RZ/V2M I2C controller Phil Edworthy
2022-06-25 20:43 ` Krzysztof Kozlowski
2022-06-27 7:17 ` Phil Edworthy
2022-06-27 9:17 ` Krzysztof Kozlowski
2022-06-24 10:17 ` [PATCH 2/2] i2c: Add Renesas RZ/V2M controller Phil Edworthy
2022-06-24 11:27 ` Arnd Bergmann
2022-06-24 11:48 ` Geert Uytterhoeven [this message]
2022-06-28 10:17 ` Andy Shevchenko
2022-06-28 10:26 ` Geert Uytterhoeven
2022-06-28 10:49 ` Phil Edworthy
2022-06-24 14:00 ` Phil Edworthy
2022-06-28 13:42 ` Geert Uytterhoeven
2022-06-28 19:29 ` Phil Edworthy
2022-06-24 11:18 ` [PATCH 0/2] i2c: Add new driver for " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWNvFARZgM1QX_t9aq1Kh84i2aCxcG5k9LqDM=wQu15pw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=jarkko.nikula@linux.intel.com \
--cc=jie.deng@intel.com \
--cc=jsd@semihalf.com \
--cc=kfting@nuvoton.com \
--cc=krzk@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=phil.edworthy@renesas.com \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sven@svenpeter.dev \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).