From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5000C433EF for ; Fri, 24 Jun 2022 11:54:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbiFXLy1 (ORCPT ); Fri, 24 Jun 2022 07:54:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231760AbiFXLy0 (ORCPT ); Fri, 24 Jun 2022 07:54:26 -0400 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA582517D6; Fri, 24 Jun 2022 04:54:25 -0700 (PDT) Received: by mail-vk1-f180.google.com with SMTP id 8so1104178vkg.10; Fri, 24 Jun 2022 04:54:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ySzXjn+gIQ0HXdMPIOBsVEFx6xUqIK4HbBW1vGEUVas=; b=7jVetdTJelvzfmm94VkhUXNYyHT5A70urPOfKMu/1tj3Jwc1g13kbBRUlx3aPUviPk uBqNlqw/yGocQ5i6s0HD/C8ReHbjwWGoEeWQoQPjjpa2O8Ctl4OkseYAwMKogbL/PM+I c4eL++ysaV+YagC2QKIB5Bqtp63CiWSnezSL+ffWNMfwDEIcowVjuC4hkZljKiS3kJQ0 5/fgKVOzGiZefZwNe5pGZu8RQRx3mwSuSAY5fqQWz7R7xM7zxsNxgM0q+O1edNupofY4 hmtQJIWAE2eq0VtVmz9HrX1DgQVutyNDMZKyTz1sm1Nn63BN492eAuWhLm2TbvEcCn6E wRDg== X-Gm-Message-State: AJIora/U/yoZzs5VwsY/WEQQSfP+XCSQ3UpQBW4IYXf52tJXEZtLCpav Ji3beeYtlAx1+MxmpTsAQGwj5nH0Hq2Gjw== X-Google-Smtp-Source: AGRyM1uwG/bw/l85vZJ/SedkDDLACPz6mAw9IG66yLks7bZoNqx4x8f2uRNIKfyJ+O6qS40OoCustA== X-Received: by 2002:a1f:31d2:0:b0:36c:ac65:5716 with SMTP id x201-20020a1f31d2000000b0036cac655716mr4314113vkx.29.1656071664796; Fri, 24 Jun 2022 04:54:24 -0700 (PDT) Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com. [209.85.222.46]) by smtp.gmail.com with ESMTPSA id b138-20020a1f1b90000000b0036c5098f621sm284355vkb.22.2022.06.24.04.54.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 04:54:24 -0700 (PDT) Received: by mail-ua1-f46.google.com with SMTP id 90so755149uam.8; Fri, 24 Jun 2022 04:54:24 -0700 (PDT) X-Received: by 2002:a5b:6c1:0:b0:669:a7c3:4c33 with SMTP id r1-20020a5b06c1000000b00669a7c34c33mr8958150ybq.543.1656071349784; Fri, 24 Jun 2022 04:49:09 -0700 (PDT) MIME-Version: 1.0 References: <20220624101736.27217-1-phil.edworthy@renesas.com> <20220624101736.27217-3-phil.edworthy@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 24 Jun 2022 13:48:58 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] i2c: Add Renesas RZ/V2M controller To: Arnd Bergmann Cc: Phil Edworthy , Philipp Zabel , Wolfram Sang , Andy Shevchenko , Jarkko Nikula , Krzysztof Kozlowski , Sam Protsenko , Rob Herring , Sven Peter , Jie Deng , Jan Dabros , Lukas Bulwahn , Tyrone Ting , Olof Johansson , Biju Das , Geert Uytterhoeven , Linux I2C , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi Arnd, On Fri, Jun 24, 2022 at 1:27 PM Arnd Bergmann wrote: > On Fri, Jun 24, 2022 at 12:17 PM Phil Edworthy > wrote: > > > > Yet another i2c controller from Renesas that is found on the RZ/V2M > > (r9a09g011) SoC. It can support only 100kHz and 400KHz operation. > > I see nothing wrong with this, just one suggestion for a cleanup: > > > +#ifdef CONFIG_PM_SLEEP > > +static int rzv2m_i2c_suspend(struct device *dev) > ...> +static const struct dev_pm_ops rzv2m_i2c_pm_ops = { > > + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(rzv2m_i2c_suspend, rzv2m_i2c_resume) > > +}; > > + > > +#define DEV_PM_OPS (&rzv2m_i2c_pm_ops) > > +#else > > +#define DEV_PM_OPS NULL > > +#endif /* CONFIG_PM_SLEEP */ > > Remove the #ifdef here, and use the new NOIRQ_SYSTEM_SLEEP_PM_OPS() > in place of SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(). Cool, TIL! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds