Re: [PATCH 4/6] arm64: renesas: draak: enable I2C controller 0 and EEPROM

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Ulrich,

On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Enables EEPROM on I2C0 on the Draak board.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts

> @@ -67,6 +72,18 @@
>         };
>  };
>
> +&i2c0 {
> +       pinctrl-0 = <&i2c0_pins>;
> +       pinctrl-names = "default";
> +       status = "okay";
> +
> +       eeprom@50 {
> +               compatible = "atmel,24c01";

This is actually a ROHM Semiconductor BR24T01FVM-W, so it should be

        compatible = "rohm,br24t01", "atmel,24c01";

Please also submit a patch to add that compatible value to
Documentation/devicetree/bindings/eeprom/eeprom.txt.

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds