From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH V2 2/5] arm: shmobile: r7s72100: add i2c clocks Date: Thu, 26 Dec 2013 22:51:34 +0100 Message-ID: References: <1387402321-21866-1-git-send-email-wsa@the-dreams.de> <1387402321-21866-3-git-send-email-wsa@the-dreams.de> <20131224024855.GC22401@verge.net.au> <20131226212539.GA2561@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: Simon Horman , Linux-sh list , Linux I2C , Magnus Damm , Laurent Pinchart , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-i2c@vger.kernel.org On Thu, Dec 26, 2013 at 10:34 PM, Geert Uytterhoeven wrote: >>> Note that after dropping these lines: >>> >>> CLKDEV_DEV_ID("fcfee000.i2c", &mstp_clks[MSTP97]), >>> CLKDEV_DEV_ID("fcfee400.i2c", &mstp_clks[MSTP96]), >>> CLKDEV_DEV_ID("fcfee800.i2c", &mstp_clks[MSTP95]), >>> CLKDEV_DEV_ID("fcfeec00.i2c", &mstp_clks[MSTP94]), >>> >>> i2c stopped working. >> >> ??? Why do you want to drop these lines? > > Your v2 dropped them, presumably in response to Sergei's ICKy comments. > And that's what Simon committed... Upon checking again, your v2 did contain them, but gmail tried to smart me out by not showing those few lines. So it must have been Simon who dropped them, or lost them during rebase? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds