From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [RFC PATCH v2 2/7] i2c: core: use I2C locking behaviour also for SMBUS Date: Mon, 4 Mar 2019 13:35:10 +0100 Message-ID: References: <20190302134735.4393-1-wsa+renesas@sang-engineering.com> <20190302134735.4393-3-wsa+renesas@sang-engineering.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190302134735.4393-3-wsa+renesas@sang-engineering.com> Sender: linux-kernel-owner@vger.kernel.org To: Wolfram Sang Cc: Linux I2C , Linux-Renesas , Linux Kernel Mailing List , Linux ARM , Keerthy , Peter Rosin , Tony Lindgren , Russell King , Andy Shevchenko , Stefan Lengfeld , Phil Reid , Tero Kristo , "open list:TI ETHERNET SWITCH DRIVER (CPSW)" , linux-tegra List-Id: linux-i2c@vger.kernel.org On Sat, Mar 2, 2019 at 2:49 PM Wolfram Sang wrote: > If I2C transfers are executed in atomic contexts, trylock is used > instead of lock. This behaviour was missing for SMBUS, although a lot of > transfers are of SMBUS type, either emulated or direct. So, factor out > the locking routine into a helper and use it for I2C and SMBUS. > > Signed-off-by: Wolfram Sang > Acked-by: Peter Rosin > Acked-by: Tony Lindgren Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds