From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulrich Hecht Subject: Re: [RFC v2 3/6] serdev: add multiplexer support Date: Wed, 16 Aug 2017 15:23:37 +0200 Message-ID: References: <1500305076-15570-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1500305076-15570-4-git-send-email-ulrich.hecht+renesas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-qt0-f195.google.com ([209.85.216.195]:35609 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbdHPNXj (ORCPT ); Wed, 16 Aug 2017 09:23:39 -0400 In-Reply-To: Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Rob Herring Cc: "linux-serial@vger.kernel.org" , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Magnus Damm , Laurent Pinchart , "wsa@the-dreams.de" , Peter Rosin , Geert Uytterhoeven , "linux-i2c@vger.kernel.org" On Wed, Jul 19, 2017 at 1:06 AM, Rob Herring wrote: >> static inline struct serdev_controller *to_serdev_controller(struct device *d) >> @@ -172,7 +180,7 @@ static inline void serdev_controller_write_wakeup(struct serdev_controller *ctrl >> { >> struct serdev_device *serdev = ctrl->serdev; >> >> - if (!serdev || !serdev->ops->write_wakeup) >> + if (!serdev || !serdev->ops || !serdev->ops->write_wakeup) > > When is ops ever NULL? Should be a separate change AFIACT. I dumped it; IIRC that happened once during development due to a bug elsewhere. CU Uli