From: Jean Pihet <jean.pihet-OTs2U3NB0ngRmelmmXo44Q@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] Revert "ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints"
Date: Wed, 14 Nov 2012 12:00:39 +0100 [thread overview]
Message-ID: <CAORVsuUAmnX1ZBrO+a0HqUVAFtsRfwCx1Vro7ERYBnJgPo095g@mail.gmail.com> (raw)
In-Reply-To: <20121114105102.GD5954-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Hi Wolfram,
On Wed, Nov 14, 2012 at 11:51 AM, Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> On Tue, Nov 06, 2012 at 04:31:32PM +0000, Paul Walmsley wrote:
>>
>> This reverts commit 3db11feffc1ad2ab9dea27789e6b5b3032827adc.
>
> Here giving the patch name in parens would have really made sense.
> Will fix that.
The title is "ARM: OMAP: convert I2C driver to PM QoS for MPU latency
constraints".
>
>> This commit causes I2C timeouts to appear on several OMAP3430/3530-based
>> boards:
>>
>> http://marc.info/?l=linux-arm-kernel&m=135071372426971&w=2
>> http://marc.info/?l=linux-arm-kernel&m=135067558415214&w=2
>> http://marc.info/?l=linux-arm-kernel&m=135216013608196&w=2
There is no formal piecof evidence that the commit is the cause of it.
>>
>> and appears to have been sent for merging before one of its prerequisites
>> was merged:
However this is correct. My fault ;-|
>>
>> http://marc.info/?l=linux-arm-kernel&m=135219411617621&w=2
>
> Hmm, any ideas how to avoid such things in the future?
The only way is to figure out the dependencies with other features. In
this case I overlooked them and assumed some other features were
already merged in. Will take care next time.
>
>> Signed-off-by: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
>
> Applied to for-current, thanks!
Thanks!
Jean
>
> --
> Pengutronix e.K. | Wolfram Sang |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2012-11-14 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 16:31 [PATCH] Revert "ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints" Paul Walmsley
2012-11-06 16:32 ` Jean Pihet
2012-11-07 6:00 ` Shubhrajyoti Datta
[not found] ` <alpine.DEB.2.00.1211061619461.20573-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2012-11-14 10:51 ` Wolfram Sang
[not found] ` <20121114105102.GD5954-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-14 11:00 ` Jean Pihet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAORVsuUAmnX1ZBrO+a0HqUVAFtsRfwCx1Vro7ERYBnJgPo095g@mail.gmail.com \
--to=jean.pihet-ots2u3nb0ngrmelmmxo44q@public.gmane.org \
--cc=aaro.koskinen-X3B1VOXEql0@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=khilman-l0cyMroinI0@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).