[PATCH -next] i2c: i2c-pxa-pci.c needs module.h

[PATCH -next] i2c: i2c-pxa-pci.c needs module.h

[Randy Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

i2c-pxa-pci.c uses interfaces from linux/module.h, so it should
include that file.  This fixes build errors.

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/i2c/busses/i2c-pxa-pci.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c
+++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c
@@ -3,6 +3,7 @@
  * It does not support slave mode, the register slightly moved. This PCI
  * device provides three bars, every contains a single I2C controller.
  */
+#include <linux/module.h>
 #include <linux/pci.h>
 #include <linux/platform_device.h>
 #include <linux/i2c/pxa-i2c.h>

Re: [PATCH -next] i2c: i2c-pxa-pci.c needs module.h

[Paul Gortmaker]

On Sat, Jul 30, 2011 at 12:14 AM, Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> wrote:
> From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
>
> i2c-pxa-pci.c uses interfaces from linux/module.h, so it should
> include that file.  This fixes build errors.

Applied to module.h-split, thanks.

P.

>
> Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-pxa-pci.c |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c
> +++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c
> @@ -3,6 +3,7 @@
>  * It does not support slave mode, the register slightly moved. This PCI
>  * device provides three bars, every contains a single I2C controller.
>  */
> +#include <linux/module.h>
>  #include <linux/pci.h>
>  #include <linux/platform_device.h>
>  #include <linux/i2c/pxa-i2c.h>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH -next] i2c: i2c-pxa-pci.c needs module.h

[Ben Dooks]

On Sat, Jul 30, 2011 at 03:09:32PM -0400, Paul Gortmaker wrote:
> On Sat, Jul 30, 2011 at 12:14 AM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> > From: Randy Dunlap <rdunlap@xenotime.net>
> >
> > i2c-pxa-pci.c uses interfaces from linux/module.h, so it should
> > include that file.  This fixes build errors.
> 
> Applied to module.h-split, thanks.

ok, so I don't need to apply this one?
Acked-by: Ben Dooks <ben-linux@fluff.org>
 
> P.
> 
> >
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > ---
> >  drivers/i2c/busses/i2c-pxa-pci.c |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > --- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c
> > +++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c
> > @@ -3,6 +3,7 @@
> >  * It does not support slave mode, the register slightly moved. This PCI
> >  * device provides three bars, every contains a single I2C controller.
> >  */
> > +#include <linux/module.h>
> >  #include <linux/pci.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/i2c/pxa-i2c.h>
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-next" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

Re: [PATCH -next] i2c: i2c-pxa-pci.c needs module.h

[Paul Gortmaker]

On Sun, Jul 31, 2011 at 12:42 PM, Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> wrote:
> On Sat, Jul 30, 2011 at 03:09:32PM -0400, Paul Gortmaker wrote:
>> On Sat, Jul 30, 2011 at 12:14 AM, Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> wrote:
>> > From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
>> >
>> > i2c-pxa-pci.c uses interfaces from linux/module.h, so it should
>> > include that file.  This fixes build errors.
>>
>> Applied to module.h-split, thanks.
>
> ok, so I don't need to apply this one?

Nope, I've got it.  There are so many implicit module.h uses, that while
farming them all out to subtrees could in theory be done, it really isn't
all that practical (or timely).

Thanks,
Paul.

> Acked-by: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
>
>> P.
>>
>> >
>> > Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
>> > ---
>> >  drivers/i2c/busses/i2c-pxa-pci.c |    1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > --- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c
>> > +++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c
>> > @@ -3,6 +3,7 @@
>> >  * It does not support slave mode, the register slightly moved. This PCI
>> >  * device provides three bars, every contains a single I2C controller.
>> >  */
>> > +#include <linux/module.h>
>> >  #include <linux/pci.h>
>> >  #include <linux/platform_device.h>
>> >  #include <linux/i2c/pxa-i2c.h>
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe linux-next" in
>> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> >
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> --
> Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/
>
> Large Hadron Colada: A large Pina Colada that makes the universe disappear.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>