From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [v12, 0/8] Fix eSDHC host version register bug Date: Tue, 18 Oct 2016 12:47:54 +0200 Message-ID: References: <1474441040-11946-1-git-send-email-yangbo.lu@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1474441040-11946-1-git-send-email-yangbo.lu-3arQi8VN3Tc@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Yangbo Lu Cc: Mark Rutland , Xiaobo Xie , Minghuan Lian , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-clk , Qiang Zhao , Russell King , Bhupesh Sharma , Jochen Friedrich , Claudiu Manoil , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Arnd Bergmann , Scott Wood , Rob Herring , Santosh Shilimkar , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mmc , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Leo Li , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Kumar List-Id: linux-i2c@vger.kernel.org On 21 September 2016 at 08:57, Yangbo Lu wrote: > This patchset is used to fix a host version register bug in the T4240-R1.0-R2.0 > eSDHC controller. To match the SoC version and revision, 10 previous version > patchsets had tried many methods but all of them were rejected by reviewers. > Such as > - dts compatible method > - syscon method > - ifdef PPC method > - GUTS driver getting SVR method > Anrd suggested a soc_device_match method in v10, and this is the only available > method left now. This v11 patchset introduces the soc_device_match interface in > soc driver. > > The first six patches of Yangbo are to add the GUTS driver. This is used to > register a soc device which contain soc version and revision information. > The other two patches introduce the soc_device_match method in soc driver > and apply it on esdhc driver to fix this bug. > > Arnd Bergmann (1): > base: soc: introduce soc_device_match() interface > > Yangbo Lu (7): > dt: bindings: update Freescale DCFG compatible > ARM64: dts: ls2080a: add device configuration node > dt: bindings: move guts devicetree doc out of powerpc directory > powerpc/fsl: move mpc85xx.h to include/linux/fsl > soc: fsl: add GUTS driver for QorIQ platforms > MAINTAINERS: add entry for Freescale SoC drivers > mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0 > > Documentation/devicetree/bindings/arm/fsl.txt | 6 +- > .../bindings/{powerpc => soc}/fsl/guts.txt | 3 + > MAINTAINERS | 11 +- > arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 6 + > arch/powerpc/kernel/cpu_setup_fsl_booke.S | 2 +- > arch/powerpc/sysdev/fsl_pci.c | 2 +- > drivers/base/Kconfig | 1 + > drivers/base/soc.c | 66 ++++++ > drivers/clk/clk-qoriq.c | 3 +- > drivers/i2c/busses/i2c-mpc.c | 2 +- > drivers/iommu/fsl_pamu.c | 3 +- > drivers/mmc/host/Kconfig | 1 + > drivers/mmc/host/sdhci-of-esdhc.c | 20 ++ > drivers/net/ethernet/freescale/gianfar.c | 2 +- > drivers/soc/Kconfig | 2 +- > drivers/soc/fsl/Kconfig | 19 ++ > drivers/soc/fsl/Makefile | 1 + > drivers/soc/fsl/guts.c | 257 +++++++++++++++++++++ > include/linux/fsl/guts.h | 125 ++++++---- > .../asm/mpc85xx.h => include/linux/fsl/svr.h | 4 +- > include/linux/sys_soc.h | 3 + > 21 files changed, 478 insertions(+), 61 deletions(-) > rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/guts.txt (91%) > create mode 100644 drivers/soc/fsl/Kconfig > create mode 100644 drivers/soc/fsl/guts.c > rename arch/powerpc/include/asm/mpc85xx.h => include/linux/fsl/svr.h (97%) > > -- > 2.1.0.27.g96db324 > This looks good to me! I am not sure which tree you want this to be picked up through, but unless no other volunteers I can take it through my mmc tree. Although, before considering to apply, I need an ack from Scott/Arnd for the guts driver in patch 5/8 and I need an ack from Greg for patch 7/8, where the soc_device_match() interface is added (seems like you didn't add him on cc/to). Kind regards Uffe