From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [v7, 0/5] Fix eSDHC host version register bug Date: Wed, 6 Apr 2016 10:14:36 +0200 Message-ID: References: <1459480051-3701-1-git-send-email-yangbo.lu@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Yangbo Lu , Scott Wood Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Zhao Qiang , Russell King , Bhupesh Sharma , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Santosh Shilimkar , linux-mmc , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jochen Friedrich , Xiaobo Xie , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , Rob Herring , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Claudiu Manoil , Kumar Gala , Yang-Leo Li , "linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-arm-kernel-IAPFreCvJWM1dQTEkxZZdg@public.gmane.org List-Id: linux-i2c@vger.kernel.org >> >> I was about to queue this for next, when I noticed that checkpatch is >> complaining/warning lots about these patches. Can you please a round of >> checkpatch and fix what makes sense. >> >> Kind regards >> Uffe > > [Lu Yangbo-B47093] Sorry about this, Uffe... No worries! > Should I ignore the warnings that update MAINTAINERS? drivers/soc/fsl/guts.c isn't part of the MAINTAINERS file, it should be. I also realize that the FREESCALE QUICC ENGINE LIBRARY section drivers/soc/fsl/qe/* also need an active maintainer, as it's currently orphan. Perhaps we should have create a new section for drivers/soc/fsl/* instead that covers all of the above? Maybe you or Scott are interested to pick it up? I also noted that, "include/linux/fsl/" isn't present in MAINTAINERS, please add that as well. > Regarding the 'undocumented' warning, I will added a patch updates doc before all the patches, Ok? Yes, good! > > Thanks a lot :) > Kind regards Uffe