Re: [PATCH v3 17/18] PCI: j721e: add reset GPIO to struct j721e_pcie

Andy Shevchenko
2024-02-15T16:05:13Z

On Thu, Feb 15, 2024 at 04:18:02PM +0100, Thomas Richard wrote:
> From: Théo Lebrun <theo.lebrun@bootlin.com>
>
> Add reset GPIO to struct j721e_pcie, so it can be used at suspend and
> resume stages.

...

> case PCI_MODE_RC:
> - gpiod = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
> - if (IS_ERR(gpiod)) {
> - ret = PTR_ERR(gpiod);
> + pcie->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
> + if (IS_ERR(pcie->reset_gpio)) {
> + ret = PTR_ERR(pcie->reset_gpio);
> if (ret != -EPROBE_DEFER)
> dev_err(dev, "Failed to get reset GPIO\n");
> goto err_get_sync;
> @@ -504,9 +504,9 @@ static int j721e_pcie_probe(struct platform_device *pdev)
> * mode is selected while enabling the PHY. So deassert PERST#
> * after 100 us.
> */
> - if (gpiod) {
> + if (pcie->reset_gpio) {
> usleep_range(100, 200);
> - gpiod_set_value_cansleep(gpiod, 1);
> + gpiod_set_value_cansleep(pcie->reset_gpio, 1);
> }

Instead of all this, just add one line assignment. Moreover, before or after
this patch refactor the code to use ret = dev_err_probe(...); pattern that
eliminates those deferral probe checks.

--
With Best Regards,
Andy Shevchenko