public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] i2c: spacemit: drop IRQF_ONESHOT flag from IRQ request
@ 2026-01-21 23:52 Yixun Lan
  2026-01-22  2:40 ` Troy Mitchell
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Yixun Lan @ 2026-01-21 23:52 UTC (permalink / raw)
  To: Andi Shyti, Troy Mitchell
  Cc: Yixun Lan, Alex Elder, linux-i2c, linux-kernel, linux-riscv,
	spacemit

In commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT without a
threaded handler")[1], it will check IRQF_ONESHOT flag in IRQ request,
and gives a warning if there is no threaded handler. Drop this flag to
fix this warning.

Link: https://lore.kernel.org/r/20260112134013.eQWyReHR@linutronix.de/ [1]
Fixes: 5ea558473fa3 ("i2c: spacemit: add support for SpacemiT K1 SoC")
Signed-off-by: Yixun Lan <dlan@kernel.org>
---
 drivers/i2c/busses/i2c-k1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c
index d42c03ef5db5..8ef6d5d1927b 100644
--- a/drivers/i2c/busses/i2c-k1.c
+++ b/drivers/i2c/busses/i2c-k1.c
@@ -566,7 +566,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev)
 		return dev_err_probe(dev, i2c->irq, "failed to get irq resource");
 
 	ret = devm_request_irq(i2c->dev, i2c->irq, spacemit_i2c_irq_handler,
-			       IRQF_NO_SUSPEND | IRQF_ONESHOT, dev_name(i2c->dev), i2c);
+			       IRQF_NO_SUSPEND, dev_name(i2c->dev), i2c);
 	if (ret)
 		return dev_err_probe(dev, ret, "failed to request irq");
 

---
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
change-id: 20260122-05-k1-i2c-irq-d1233dd8f194

Best regards,
-- 
Yixun Lan <dlan@kernel.org>


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] i2c: spacemit: drop IRQF_ONESHOT flag from IRQ request
  2026-01-21 23:52 [PATCH] i2c: spacemit: drop IRQF_ONESHOT flag from IRQ request Yixun Lan
@ 2026-01-22  2:40 ` Troy Mitchell
  2026-01-22  8:06 ` Javier Martinez Canillas
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Troy Mitchell @ 2026-01-22  2:40 UTC (permalink / raw)
  To: Yixun Lan, Andi Shyti, Troy Mitchell
  Cc: Alex Elder, linux-i2c, linux-kernel, linux-riscv, spacemit

On Thu Jan 22, 2026 at 7:52 AM CST, Yixun Lan wrote:
> In commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT without a
> threaded handler")[1], it will check IRQF_ONESHOT flag in IRQ request,
> and gives a warning if there is no threaded handler. Drop this flag to
> fix this warning.
>
> Link: https://lore.kernel.org/r/20260112134013.eQWyReHR@linutronix.de/ [1]
> Fixes: 5ea558473fa3 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> Signed-off-by: Yixun Lan <dlan@kernel.org>
Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] i2c: spacemit: drop IRQF_ONESHOT flag from IRQ request
  2026-01-21 23:52 [PATCH] i2c: spacemit: drop IRQF_ONESHOT flag from IRQ request Yixun Lan
  2026-01-22  2:40 ` Troy Mitchell
@ 2026-01-22  8:06 ` Javier Martinez Canillas
  2026-01-22 13:14 ` Andi Shyti
  2026-01-26  4:21 ` patchwork-bot+linux-riscv
  3 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2026-01-22  8:06 UTC (permalink / raw)
  To: Yixun Lan, Andi Shyti, Troy Mitchell
  Cc: Yixun Lan, Alex Elder, linux-i2c, linux-kernel, linux-riscv,
	spacemit

Yixun Lan <dlan@kernel.org> writes:

> In commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT without a
> threaded handler")[1], it will check IRQF_ONESHOT flag in IRQ request,
> and gives a warning if there is no threaded handler. Drop this flag to
> fix this warning.
>
> Link: https://lore.kernel.org/r/20260112134013.eQWyReHR@linutronix.de/ [1]
> Fixes: 5ea558473fa3 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] i2c: spacemit: drop IRQF_ONESHOT flag from IRQ request
  2026-01-21 23:52 [PATCH] i2c: spacemit: drop IRQF_ONESHOT flag from IRQ request Yixun Lan
  2026-01-22  2:40 ` Troy Mitchell
  2026-01-22  8:06 ` Javier Martinez Canillas
@ 2026-01-22 13:14 ` Andi Shyti
  2026-01-26  4:21 ` patchwork-bot+linux-riscv
  3 siblings, 0 replies; 5+ messages in thread
From: Andi Shyti @ 2026-01-22 13:14 UTC (permalink / raw)
  To: Yixun Lan
  Cc: Troy Mitchell, Alex Elder, linux-i2c, linux-kernel, linux-riscv,
	spacemit

Hi Yixun,

On Thu, Jan 22, 2026 at 07:52:00AM +0800, Yixun Lan wrote:
> In commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT without a
> threaded handler")[1], it will check IRQF_ONESHOT flag in IRQ request,
> and gives a warning if there is no threaded handler. Drop this flag to
> fix this warning.
> 
> Link: https://lore.kernel.org/r/20260112134013.eQWyReHR@linutronix.de/ [1]
> Fixes: 5ea558473fa3 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> Signed-off-by: Yixun Lan <dlan@kernel.org>

merged to i2c/i2c-host-fixes.

Thanks,
Andi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] i2c: spacemit: drop IRQF_ONESHOT flag from IRQ request
  2026-01-21 23:52 [PATCH] i2c: spacemit: drop IRQF_ONESHOT flag from IRQ request Yixun Lan
                   ` (2 preceding siblings ...)
  2026-01-22 13:14 ` Andi Shyti
@ 2026-01-26  4:21 ` patchwork-bot+linux-riscv
  3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+linux-riscv @ 2026-01-26  4:21 UTC (permalink / raw)
  To: Yixun Lan
  Cc: linux-riscv, andi.shyti, troy.mitchell, elder, linux-i2c,
	linux-kernel, spacemit

Hello:

This patch was applied to riscv/linux.git (fixes)
by Andi Shyti <andi.shyti@kernel.org>:

On Thu, 22 Jan 2026 07:52:00 +0800 you wrote:
> In commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT without a
> threaded handler")[1], it will check IRQF_ONESHOT flag in IRQ request,
> and gives a warning if there is no threaded handler. Drop this flag to
> fix this warning.
> 
> Link: https://lore.kernel.org/r/20260112134013.eQWyReHR@linutronix.de/ [1]
> Fixes: 5ea558473fa3 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> 
> [...]

Here is the summary with links:
  - i2c: spacemit: drop IRQF_ONESHOT flag from IRQ request
    https://git.kernel.org/riscv/c/e351836a54e3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-01-26  4:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-21 23:52 [PATCH] i2c: spacemit: drop IRQF_ONESHOT flag from IRQ request Yixun Lan
2026-01-22  2:40 ` Troy Mitchell
2026-01-22  8:06 ` Javier Martinez Canillas
2026-01-22 13:14 ` Andi Shyti
2026-01-26  4:21 ` patchwork-bot+linux-riscv

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox