From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Rosen Penev" <rosenp@gmail.com>, <linux-i2c@vger.kernel.org>
Cc: "Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Kees Cook" <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:KERNEL HARDENING (not covered by other
areas):Keyword:b__counted_by(_le|_be)?b"
<linux-hardening@vger.kernel.org>,
"Cosmin Tanislav" <demonsingur@gmail.com>,
"Romain Gantois" <romain.gantois@bootlin.com>
Subject: Re: [PATCH] i2c: atr: use kzalloc_flex
Date: Fri, 27 Mar 2026 09:12:46 +0100 [thread overview]
Message-ID: <DHDEWIRRJTP1.58HXGTBGH4A@bootlin.com> (raw)
In-Reply-To: <20260327030310.8502-1-rosenp@gmail.com>
Hello Rosen,
+Cc Cosmin, Romain
On Fri Mar 27, 2026 at 4:03 AM CET, Rosen Penev wrote:
> Convert kzalloc_obj + kcalloc to kzalloc_flex to save an allocation.
>
> Add __counted_by to get extra runtime analysis.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
This is the second version of the previous patch, so the subject line
should start with "[PATCH v2]". You may try using b4 to automate this, it
takes over this and many other boring-but-useful details.
Additionally I suspect b4 would have a more complete Cc list, including
recent contributors to this driver like Cosmin Tanislav and Romain Gantois
who might want to review this patch. I'm Cc-ing them this time.
> ---
Also a changelog would be nice after the '---' marker, to help reviewers,
and a link to previous versions. It took a moment to me to realize I had
already reviewed almost the exact same code.
Other than than the patch looks good:
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-03-27 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 3:03 [PATCH] i2c: atr: use kzalloc_flex Rosen Penev
2026-03-27 8:12 ` Luca Ceresoli [this message]
2026-03-27 18:35 ` Rosen Penev
-- strict thread matches above, loose matches on Subject: below --
2026-03-13 0:23 Rosen Penev
2026-03-13 8:17 ` Luca Ceresoli
2026-03-13 21:48 ` Rosen Penev
2026-03-30 8:50 ` Romain Gantois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHDEWIRRJTP1.58HXGTBGH4A@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=demonsingur@gmail.com \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romain.gantois@bootlin.com \
--cc=rosenp@gmail.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox