Re: [RESEND][PATCH v5] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip

Re: [RESEND][PATCH v5] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip

[Vincent Legoll]

Hi Aurelien,

On 4/6/26 17:42, Aurelien Jarno wrote:
> On 2026-04-06 11:46, Vincent Legoll wrote:
>> Tell me if there's a new iteration to test, and/or if you want me testing it
>> in a different way.
> Yes, as written in the original mail, this patchset depends on PIO
> support in the spacemit I2C driver:
> https://lore.kernel.org/lkml/20260207-b4-k3-i2c-pio-v7-2-626942d94d91@linux.spacemit.com/
>
> Without it, you might get this warning message and reboot is not 100%
> reliable. I still believe it's better than no reboot support at all.


OK, I tested a new stack: next-20260406, PIO patchset, reset patchset & 
USB patchset:


$ git log --oneline
5030369b32c4 (HEAD -> opirv2-pio-reset-usb) riscv: dts: spacemit: Enable 
USB3.0/PCIe on OrangePi RV2
73274ce37441 riscv: dts: spacemit: Define the P1 PMIC regulators for 
OrangePi RV2
cda12b8bdbfe riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2
68ce409351c6 (opirv2-pio-reset) mfd: simple-mfd-i2c: add a reboot cell 
for the SpacemiT P1 chip
245e0b8e8a91 i2c: spacemit: introduce pio for k1
a588d756621d i2c: spacemit: move i2c_xfer_msg()
816f193dd0d9 (tag: next-20260406, next/master, next/HEAD) Add linux-next 
specific files for 20260406

This boots and reset properly without the previous WARN.

So if any of those those series need added T-Bs, then here's mine:

Tested-by: Vincent Legoll<legoll@online.fr> # OrangePi-RV2

I also believe this is better than nothing: reboot + (harmless) WARN instead of hang.

PS: I added recipients for the PIO patchset as CC here, for the T-B, hope this is not bothering.

Thanks

Re: [RESEND][PATCH v5] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip

[Troy Mitchell]

On Tue Apr 7, 2026 at 5:55 AM CST, Vincent Legoll wrote:
> Hi Aurelien,
>
> On 4/6/26 17:42, Aurelien Jarno wrote:
>> On 2026-04-06 11:46, Vincent Legoll wrote:
>>> Tell me if there's a new iteration to test, and/or if you want me testing it
>>> in a different way.
>> Yes, as written in the original mail, this patchset depends on PIO
>> support in the spacemit I2C driver:
>> https://lore.kernel.org/lkml/20260207-b4-k3-i2c-pio-v7-2-626942d94d91@linux.spacemit.com/
>>
>> Without it, you might get this warning message and reboot is not 100%
>> reliable. I still believe it's better than no reboot support at all.
>
>
> OK, I tested a new stack: next-20260406, PIO patchset, reset patchset & 
> USB patchset:
>
>
> $ git log --oneline
> 5030369b32c4 (HEAD -> opirv2-pio-reset-usb) riscv: dts: spacemit: Enable 
> USB3.0/PCIe on OrangePi RV2
> 73274ce37441 riscv: dts: spacemit: Define the P1 PMIC regulators for 
> OrangePi RV2
> cda12b8bdbfe riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2
> 68ce409351c6 (opirv2-pio-reset) mfd: simple-mfd-i2c: add a reboot cell 
> for the SpacemiT P1 chip
> 245e0b8e8a91 i2c: spacemit: introduce pio for k1
> a588d756621d i2c: spacemit: move i2c_xfer_msg()
> 816f193dd0d9 (tag: next-20260406, next/master, next/HEAD) Add linux-next 
> specific files for 20260406
>
> This boots and reset properly without the previous WARN.
>
> So if any of those those series need added T-Bs, then here's mine:
>
> Tested-by: Vincent Legoll<legoll@online.fr> # OrangePi-RV2
I'll take this tag to my PIO patchset. Thanks!

                                - Troy