Linux I2C development
 help / color / mirror / Atom feed
From: "Brigham Campbell" <me@brighamcampbell.com>
To: "Stephen Horvath" <s.horvath@outlook.com.au>,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Jean Delvare" <jdelvare@suse.de>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Cc: "Guenter Roeck" <linux@roeck-us.net>,
	"Kamil Aronowski" <kamil.aronowski@3mdeb.com>
Subject: Re: [PATCH i2c-tools v3 2/8] decode-dimms: Decode DDR5 Manufacturer Data
Date: Wed, 08 Jul 2026 00:48:15 -0600	[thread overview]
Message-ID: <DJSZLX53OSFO.3AMQ57D7GX3JN@brighamcampbell.com> (raw)
In-Reply-To: <20260629-ddr5-v3-2-07f45075a51a@outlook.com.au>

On Mon Jun 29, 2026 at 1:10 AM MDT, Stephen Horvath wrote:
> Decode the DRAM's manufacturer data for DDR5.
> There are more manufacturers in the common and type specific sections,
> but only the 'Manufacturing Information' section of the eeprom has been
> implemented.

The overlap (and possible collision) between ASCII-encoded and
binary-encoded DRAM stepping values is unfortunate, but that's clearly a
shortcoming of the JEDEC standard itself, not your code.

Reviewed-by: Brigham Campbell <me@brighamcampbell.com>

I'll try to provide feedback on the rest of the series tomorrow evening.

Cheers!
-- 
Brigham Campbell
https://brighamcampbell.com


  reply	other threads:[~2026-07-08  6:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  7:09 [PATCH i2c-tools v3 0/8] decode-dimms: Implement DDR5 decoding Stephen Horvath
2026-06-29  7:10 ` [PATCH i2c-tools v3 1/8] decode-dimms: Implement DDR5 checksum parsing Stephen Horvath
2026-07-08  5:33   ` Brigham Campbell
2026-07-09 12:21     ` Stephen Horvath
2026-06-29  7:10 ` [PATCH i2c-tools v3 2/8] decode-dimms: Decode DDR5 Manufacturer Data Stephen Horvath
2026-07-08  6:48   ` Brigham Campbell [this message]
2026-06-29  7:10 ` [PATCH i2c-tools v3 3/8] decode-dimms: Decode timings and other data for DDR5 Stephen Horvath
2026-07-09 13:59   ` Brigham Campbell
2026-07-12  3:26     ` Stephen Horvath
2026-06-29  7:10 ` [PATCH i2c-tools v3 4/8] decode-dimms: Decode DDR5 common module information Stephen Horvath
2026-06-29  7:10 ` [PATCH i2c-tools v3 5/8] decode-dimms: Add basic decoding of type specific information for DDR5 Stephen Horvath
2026-06-29  7:10 ` [PATCH i2c-tools v3 6/8] decode-dimms: Add second level separator Stephen Horvath
2026-06-29  7:10 ` [PATCH i2c-tools v3 8/8] decode-dimms: Add DDR5 XMP 3.0 and EXPO decoding Stephen Horvath
2026-06-29  7:10 ` [PATCH i2c-tools v3 7/8] decode-dimms: Decode DDR5 error log Stephen Horvath
2026-06-29  9:05 ` [PATCH i2c-tools v3 0/8] decode-dimms: Implement DDR5 decoding Wolfram Sang
2026-06-29 13:40   ` Stephen Horvath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJSZLX53OSFO.3AMQ57D7GX3JN@brighamcampbell.com \
    --to=me@brighamcampbell.com \
    --cc=jdelvare@suse.de \
    --cc=kamil.aronowski@3mdeb.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=s.horvath@outlook.com.au \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox