From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f43.google.com (mail-pj2-f43.google.com [74.125.227.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95CD44FC324 for ; Mon, 21 Sep 2026 18:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790015537; cv=none; b=dA1jaJGu/k6klqCMtS263BjaTZGJ7hSZxDUFEjv0Sx+zrkxkabjmJtX2XcrqC6pKSdQN6MpyuYkrfqOztcbZs34z5vtA10MVY3qUkaN1mXNssCaosSftVMmCN6niRaE7fzNth4u8/b2IcAfMqnUzEqIiJAAjFQMypAtCbDYucT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790015537; c=relaxed/simple; bh=8BaAO/JTedLrIStDBlrZRjwux1WdgbCnv3+4CtQ+5po=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=nhWjiZx0ZDKUj+8cM+BBZ0/PDhwBswwFSVjdRSow09QOHnjHGKmXnet+dMGONh5xM7eNOPZe6bfKp2mBbRFb2pHJR7M35oKCvCla4CXu2805ElaEK041dqSFQJb8Uktn6+LbiBs8lK4JFwGQ3Xr5s5J7OrotdpnKsHRYsLSgkM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai; spf=pass smtp.mailfrom=nexthop.ai; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b=QIgvXKP6; arc=none smtp.client-ip=74.125.227.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b="QIgvXKP6" Received: by mail-pj2-f43.google.com with SMTP id 98e67ed59e1d1-396ccc02279so2630416a91.1 for ; Mon, 21 Sep 2026 11:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexthop.ai; s=google; t=1790015536; x=1790620336; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=8BaAO/JTedLrIStDBlrZRjwux1WdgbCnv3+4CtQ+5po=; b=QIgvXKP6cjWgHpN8Ep1F31SfUVgSyF+QsAqzUSGF5VYyQD7nO5AL7oina2cyOvtYwc lYmSbsiRR/qjmGEFoj74RUGeIbffJrtApacxuNM1r36x9NExf03LyB4t0YcDgUU/msAU 0TYJlagRORlFnlAMyrruqnC/5wnLTFV2h9POxsWCg9crYiM1oglukfM6Jl9IQBZcvDss 2vl3wyRy389M34ACa4TeF94M0WSs3wiQJCcc76Z4qkQCzlrMiBscW7Ar2aImkKmXeYRB eOlI7ZM9aqAuU+m1pgt2PiqHrw+sTUstn45CECaCaVIfJR03ZC9O0PHqNmiVdjPGvnre /GGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790015536; x=1790620336; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8BaAO/JTedLrIStDBlrZRjwux1WdgbCnv3+4CtQ+5po=; b=HiSkIPgDKklNbNTmhRFfjnSRZP12sTt/ZzQm2rEeP2sGFgXlHYVMh5o0qAlJo79R4G xcUrr5I9/8fmoxSFTEGtFC06kD4g5PSKk999wpd9x5Gk4ZYWbz5NQ3zYKxkLTwRWq91f 23d6u0VndiwxxKq0b3n2Ij0OFvis1fSAnLIp/emIQ5tXAvwmN13kvYpM8G6eSobw2/kD 24T9PygJmETBT5IJoN1q2i2san+qhNZV9GwJoeuDtoriurQk9Ql9cwyi+NHlNCCWQLB2 w0ChlCPMg+rtDJ4sFW/ndV3rfoGCVU2AiDOIRnIOvEqBz0FS92nLl+cG/TNz2BxQMwyD UMCw== X-Forwarded-Encrypted: i=1; AKwUvBxMPSaep5bnYX7iEgzUfVfM2ubsI49uzXytXEViD7XQEcFl+c3rrg6LeWfXi6O0/2EnoSqWyb9NcUE=@vger.kernel.org X-Gm-Message-State: AFuF++nuQOSzZ/ozcjzHhi2HYKPlEojbIFyNWuozTHv9VQDij43O2wpK z7mi85qvfRnd9R2ddKbyFAlKaYCEOyUk38prCsZ2PSGA64E9zHcGTBo4IUpPNI/nudSmfpywcJd kJ5Tt6F0= X-Gm-Gg: AYBFou3IzJEUZklhtqyrcs4bjZ/PSUebzxQq0baHN+7kLcB+45NCElIaKbuaA6titUC XyZhdug2dJy+OmQItpBt6an9e9WBSv1v4pmDhgluLT2y3P5ISowHy8S3dTKRBoMtlGHlD+/pGkI qZXXQsyXtsJK5asGGpD5s7D6ok5XgPYU55EbmNCyikno16nrKs2fIkFrrze+tIUZ7BgXjIP+sRG xh9noD0FNDb8AErSndJcAHEcZBJC3N6jmzMH97wjBFSibaolbDr6RvJ9Qo3WqD305g7S7YOzEO/ 4a4m4lMukhkO31sQ7GRULmEiuApaUXgGo+ZS5xpH6EurQQvDtaY+w/lJwx5ynxXwSTHBXWjyKLK F9P/LZF2tPhPOgegz6hlGTm6d3vbhU2vJrkVaOk4LycEbCkcqynZA39csoZPoQXuuKbPcaBTNcb NlG18J/Djdb92hjBhE7F9FMXz0YeXfGubjnXRAP2Et5CoEQrmPgji2Tt2PojhsN3/eVf9+zQs= X-Received: by 2002:a17:90b:3a43:b0:39e:6c68:c778 with SMTP id 98e67ed59e1d1-39e6c68ca12mr11774403a91.46.1790015535822; Mon, 21 Sep 2026 11:32:15 -0700 (PDT) Received: from localhost ([50.145.100.174]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-144da432647sm32883863c88.5.2026.09.21.11.32.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Sep 2026 11:32:15 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 21 Sep 2026 11:32:13 -0700 Message-Id: Subject: Re: [PATCH v7] i2c: xiic: restore non-managed runtime PM to fix clk WARN flood From: "Abdurrahman Hussain" To: "Andy Shevchenko" , "Abdurrahman Hussain" Cc: "Michal Simek" , "Andi Shyti" , , , X-Mailer: aerc 0.22.0 References: <20260821-i2c-xiic-restore-runtime-pm-teardown-v7-1-954e06765144@nexthop.ai> In-Reply-To: On Wed Sep 9, 2026 at 11:40 PM PDT, Andy Shevchenko wrote: > On Wed, Sep 09, 2026 at 08:51:33PM -0700, Abdurrahman Hussain wrote: >> On Fri Aug 21, 2026 at 6:12 PM PDT, Abdurrahman Hussain wrote: > >> Gentle ping on this one. It has been quiet since v7 went out on Aug 21. >> >> Andy, v4 onwards switched to request_threaded_irq()/free_irq() with the >> explicit free in the probe error path and in remove(), per your comment = on >> v3. Does that address your concern, or is there anything else you would >> like changed? > > Seems okay to me. > >> Andi, this is a regression fix for 50c63491ff26 (the devres conversion), >> and the WARN fires on every unbind/rmmod of the driver, so it would be >> good to get it into 7.2 or early 7.3 fixes if the patch looks OK to you. > > v7.2 is already released, so v7.3-rcX is the best you can get. > >> Happy to respin if anything is still open. Andi, ping on this one. It is a regression from my own 50c63491ff26 ("i2c: xiic: switch to devres managed APIs"), which landed in v7.1, so both v7.1 and v7.2 WARN on every unbind/rmmod of the driver. Andy was happy with v7 [1]. Could you take it for 7.3 fixes? Abdurrahman