From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Loeliger Subject: Re: [PATCH 2/3] Convert PowerPC MPC i2c to of_platform_driver from platform_driver Date: Wed, 23 Jan 2008 08:31:09 -0600 Message-ID: References: <20080123020912.31675.48787.stgit@terra.home> <20080123020914.31675.35659.stgit@terra.home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Your message of "Tue, 22 Jan 2008 21:09:14 EST." <20080123020914.31675.35659.stgit@terra.home> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Jon Smirl Cc: linuxppc-dev@ozlabs.org, i2c@lm-sensors.org List-Id: linux-i2c@vger.kernel.org So, like, the other day Jon Smirl mumbled: > Convert MPC i2c driver from a platform_driver to a > of_platform_driver. Add the ability to dynamically load i2c drivers > based on device tree names. Routine names were changed from fsl_ to > mpc_ to make them match the file name. Common code moved to > powerpc-common.* Orginal ppc driver left intact for deletion when ppc > arch is removed. This seems backwards to me. I was under the impression that our trend was _toward_ "Freescale" and "fsl" names...? And aren't the drivers also already using "fsl-i2c" in the DTS files as called out in the b-w-o.txt too? Grumble long lines not hard-limited to 70-ish columns, yes, even in log messages... :-) jdl