Re: [PATCH 3/3] Add device tree compatible aliases to i2c drivers

Jon Smirl
2008-01-23T20:30:27Z

On 1/23/08, Matt Sealey <matt@genesi-usa.com> wrote:
>
>
> Jon Smirl wrote:
> > --- a/drivers/i2c/chips/tps65010.c
> > +++ b/drivers/i2c/chips/tps65010.c
> > @@ -571,6 +571,10 @@ static const struct i2c_device_id tps65010_id[] = {
> > { "tps65011", TPS65011 },
> > { "tps65012", TPS65012 },
> > { "tps65013", TPS65013 },
> > + OF_ID("ti,tps65010", TPS65010)
> > + OF_ID("ti,tps65011", TPS65011)
> > + OF_ID("ti,tps65012", TPS65012)
> > + OF_ID("ri,tps65013", TPS65013)
> > { },
>
> ti, ti, ti, ri?
>
> > --- a/drivers/rtc/rtc-ds1307.c
> > +++ b/drivers/rtc/rtc-ds1307.c
> > @@ -129,6 +129,12 @@ static const struct i2c_device_id ds1307_id[] = {
> > { "ds1339", ds_1339 },
> > { "ds1340", ds_1340 },
> > { "m41t00", m41t00 },
> > + OF_ID("dallas,ds1307", ds_1307)
> > + OF_ID("dallas,ds1337", ds_1337)
> > + OF_ID("dallas,ds1338", ds_1338)
> > + OF_ID("dallas,ds1339", ds_1339)
> > + OF_ID("dallas,ds1340", ds_1340)
> > + OF_ID("stm,m41t00", m41t00)
> > {},
> > };
>
> The convention is to use the stock ticker, capitalized, if a company
> has one, I guess dallas is MXIM these days, but dallas is a good
> substitute based on the fact that most people still remember Dallas
> clock chips and so on from the Ancient Days. STMicroelectronics is STM.
> I couldn't care less about case sensitivity, but the stock ticker
> thing was always a good idea.. it gives a sort of grounding in reality
> for the manufacturer names.

I'll put in whatever the Open Firmware police tell me to. We just all
need to come to an agreement.

> Are we still following this convention or are the names of devices
> simply arbitrarily defined by Linux kernel developers now?
>
> --
> Matt Sealey <matt@genesi-usa.com>
> Genesi, Manager, Developer Relations
>

--
Jon Smirl
jonsmirl@gmail.com