From: Russell King <rmk+kernel@armlinux.org.uk>
To: linux-i2c@vger.kernel.org
Subject: [PATCH 3/4] i2c: pxa: ensure timeout messages are unique
Date: Wed, 06 May 2020 10:29:22 +0100 [thread overview]
Message-ID: <E1jWGMk-0000NP-Vi@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <20200506092831.GN1551@shell.armlinux.org.uk>
Ensure that the various timeout messages can identify where in the code
they were produced from to aid debugging.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
drivers/i2c/busses/i2c-pxa.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index f20f8b905793..0becab239476 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -1095,7 +1095,7 @@ static int i2c_pxa_do_xfer(struct pxa_i2c *i2c, struct i2c_msg *msg, int num)
ret = i2c->msg_idx;
if (!timeout && i2c->msg_num) {
- i2c_pxa_scream_blue_murder(i2c, "timeout");
+ i2c_pxa_scream_blue_murder(i2c, "timeout with active message");
ret = I2C_RETRY;
}
@@ -1169,7 +1169,7 @@ static int i2c_pxa_pio_set_master(struct pxa_i2c *i2c)
if (timeout < 0) {
show_state(i2c);
dev_err(&i2c->adap.dev,
- "i2c_pxa: timeout waiting for bus free\n");
+ "i2c_pxa: timeout waiting for bus free (set_master)\n");
return I2C_RETRY;
}
@@ -1213,7 +1213,7 @@ static int i2c_pxa_do_pio_xfer(struct pxa_i2c *i2c,
out:
if (timeout == 0) {
- i2c_pxa_scream_blue_murder(i2c, "timeout");
+ i2c_pxa_scream_blue_murder(i2c, "timeout (do_pio_xfer)");
ret = I2C_RETRY;
}
--
2.20.1
next prev parent reply other threads:[~2020-05-06 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 9:28 [PATCH 0/4] Further i2c-pxa cleanups Russell King - ARM Linux admin
2020-05-06 9:29 ` [PATCH 1/4] i2c: pxa: consolidate i2c_pxa_*xfer() implementations Russell King
2020-05-11 19:59 ` Wolfram Sang
2020-05-11 20:20 ` Russell King - ARM Linux admin
2020-05-06 9:29 ` [PATCH 2/4] i2c: pxa: avoid complaints with non-responsive slaves Russell King
2020-05-06 9:29 ` Russell King [this message]
2020-05-06 9:29 ` [PATCH 4/4] i2c: pxa: remove some unnecessary debug Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1jWGMk-0000NP-Vi@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).