From: Russell King <rmk+kernel@armlinux.org.uk>
To: linux-i2c@vger.kernel.org
Subject: [PATCH v2 4/4] i2c: pxa: remove some unnecessary debug
Date: Mon, 11 May 2020 22:10:42 +0100 [thread overview]
Message-ID: <E1jYFhC-0007KN-Ll@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <20200511210948.GY1551@shell.armlinux.org.uk>
Remove unnecessary show_state() in the loop inside
i2c_pxa_pio_set_master(), which can be unnecessarily verbose.
Remove the i2c_pxa_scream_blue_murder() in i2c_pxa_pio_xfer(), which
will trigger if we are probing the I2C bus and a slave does not
respond; this is a normal event, and not something to report.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
drivers/i2c/busses/i2c-pxa.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index 0becab239476..db739cce93ac 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -1161,10 +1161,8 @@ static int i2c_pxa_pio_set_master(struct pxa_i2c *i2c)
/*
* Wait for the bus to become free.
*/
- while (timeout-- && readl(_ISR(i2c)) & (ISR_IBB | ISR_UB)) {
+ while (timeout-- && readl(_ISR(i2c)) & (ISR_IBB | ISR_UB))
udelay(1000);
- show_state(i2c);
- }
if (timeout < 0) {
show_state(i2c);
--
2.20.1
next prev parent reply other threads:[~2020-05-11 21:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 21:09 [PATCH v2 0/4] Further i2c-pxa cleanups Russell King - ARM Linux admin
2020-05-11 21:10 ` [PATCH v2 1/4] i2c: pxa: consolidate i2c_pxa_*xfer() implementations Russell King
2020-05-12 10:35 ` Wolfram Sang
2020-05-11 21:10 ` [PATCH v2 2/4] i2c: pxa: avoid complaints with non-responsive slaves Russell King
2020-05-12 10:35 ` Wolfram Sang
2020-05-11 21:10 ` [PATCH v2 3/4] i2c: pxa: ensure timeout messages are unique Russell King
2020-05-12 10:35 ` Wolfram Sang
2020-05-11 21:10 ` Russell King [this message]
2020-05-12 10:35 ` [PATCH v2 4/4] i2c: pxa: remove some unnecessary debug Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1jYFhC-0007KN-Ll@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).