From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guennadi Liakhovetski Subject: Re: [PATCH 4/4 v2] soc-camera: add support for MT9T031 CMOS camera sensor from Micron Date: Mon, 22 Dec 2008 17:48:26 +0100 (CET) Message-ID: References: <200812221737.42194.khali@linux-fr.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <200812221737.42194.khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jean Delvare Cc: video4linux-list-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Mon, 22 Dec 2008, Jean Delvare wrote: > Hi Guennadi, >=20 > Le Jeudi 18 D=E9cembre 2008 09:40, Guennadi Liakhovetski a =E9crit=A0= : > > From: Guennadi Liakhovetski > >=20 > > This camera is rather similar to MT9M001, but also has a couple of > > enhanced features, like pixel binning. >=20 > I didn't look at the datasheets, but just to make sure you didn't > overlook this possibility: wouldn't it make sense to have a single > driver for both devices? The i2c subsystem architecture makes this > easy. Yes, I thought about this, but at least in the present version that=20 binning / skipping difference does make up a significant part of the=20 driver, so, I preferred to make a separate one. > > Signed-off-by: Guennadi Liakhovetski > > --- > >=20 > > Changes since v1: added > >=20 > > i2c_set_clientdata(client, NULL); > >=20 > > in error path and in remove. > >=20 > > drivers/media/video/Kconfig | 6 + > > drivers/media/video/Makefile | 1 + > > drivers/media/video/mt9t031.c | 733 +++++++++++++++++++++++++++= ++++++++++++ > > include/media/v4l2-chip-ident.h | 1 + > > 4 files changed, 741 insertions(+), 0 deletions(-) > > create mode 100644 drivers/media/video/mt9t031.c > > (...) >=20 > I took a quick look at the code and it looks fine to me, for the > parts I can comment on. So this is: >=20 > Acked-by: Jean Delvare Good, thanks. Guennadi --- Guennadi Liakhovetski, Ph.D. =46reelance Open-Source Software Developer