From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guennadi Liakhovetski Subject: Re: v4l2-subdev Re: [PATCH 0/5] soc-camera: convert to platform device Date: Mon, 20 Apr 2009 16:18:41 +0200 (CEST) Message-ID: References: <20090420140411.GE8776@sirena.org.uk> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <20090420140411.GE8776-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Magnus Damm , Linux Media Mailing List , Robert Jarzmik , Kuninori Morimoto , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Greg KH , Mauro Carvalho Chehab List-Id: linux-i2c@vger.kernel.org On Mon, 20 Apr 2009, Mark Brown wrote: > On Mon, Apr 20, 2009 at 03:50:44PM +0200, Guennadi Liakhovetski wrote: > > > break if we move it down right after i2c? Another hackish interim solution > > would be to replace module_init with subsys_init in i2c-sh_mobile.c like > > some other i2c adapters do (including MXC, PXA). That's certainly easier, > > but then we'd also have to modify i2c-imx, later maybe i2c-at91.c... > > That'd be sensible long term anyway - voltage and current regulators are > often I2C devices and they need to be initialised very early in order to > be available for general use. If there are other requirements to have i2c initialise early we can well move it up the chain. I think it would be preferable to modifying each i2c host adapter driver to use subsys_init(). Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/