Re: [PATCH v2 08/10] i2c: i801: centralize configuring block commands in i801_block_transaction

Jean Delvare
2023-02-15T15:16:31Z

On Mon, 19 Dec 2022 19:21:33 +0100, Heiner Kallweit wrote:
> Similar to the patch for non-block commands, centralize block command
> register settings in i801_block_transaction().
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/i2c/busses/i2c-i801.c | 85 +++++++++++++++--------------------
> 1 file changed, 36 insertions(+), 49 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 0d49e9587..78663d8df 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> (...)
> @@ -824,6 +846,13 @@ static int i801_block_transaction(struct i801_priv *priv, union i2c_smbus_data *
> "I2C block read is unsupported!\n");
> return -EOPNOTSUPP;
> }
> +

No blank line here.

> + break;
> + case I2C_SMBUS_BLOCK_PROC_CALL:
> + /* Needs to be flagged as write transaction */
> + i801_set_hstadd(priv, addr, I2C_SMBUS_WRITE);
> + outb_p(hstcmd, SMBHSTCMD(priv));
> + break;
> }
>
> /* Experience has shown that the block buffer can only be used for

Other that this minor style issue, looks good, nice clean-up.

Reviewed-by: Jean Delvare <jdelvare@suse.de>

--
Jean Delvare
SUSE L3 Support