Re: [PATCH v2 01/10] i2c: i801: improve interrupt handler

Jean Delvare
2023-02-10T08:28:20Z

On Mon, 19 Dec 2022 19:13:44 +0100, Heiner Kallweit wrote:
> Not sure if it can happen, but better play safe: If SMBHSTSTS_BYTE_DONE
> and an error flag is set, then don't trust the result and skip calling
> i801_isr_byte_done(). In addition clear status bit SMBHSTSTS_BYTE_DONE
> in the main interrupt handler, this allows to simplify the code a
> little.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - change one expression for generating less binary code
> ---
> drivers/i2c/busses/i2c-i801.c | 25 ++++++++-----------------
> 1 file changed, 8 insertions(+), 17 deletions(-)
> (...)

Reviewed-by: Jean Delvare <jdelvare@suse.de>

--
Jean Delvare
SUSE L3 Support