Re: [PATCH v2 10/10] i2c: i801: call i801_check_post() from i801_access()

Heiner Kallweit
2023-02-15T17:17:06Z

On 15.02.2023 18:09, Jean Delvare wrote:
> Hi Heiner,
>
> On Mon, 19 Dec 2022 19:22:42 +0100, Heiner Kallweit wrote:
>> Avoid code duplication by calling i801_check_post() from i801_access().
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> drivers/i2c/busses/i2c-i801.c | 20 +++++++++-----------
>> 1 file changed, 9 insertions(+), 11 deletions(-)
>> (...)
>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
> So I'm done reviewing the series. I have also tested the result,
> successfully, albeit my coverage is limited.
>
> Patches 1-4 have been committed by Wolfram already. Patches 6, 7 and 8
> have minor issues. I can take care of resubmitting if you want.
>
This would be great, thanks!

> My suggested changes (renaming function parameters and storing the
> original value of SMBAUXCTL) are better implemented on top of that
> later (if you agree with them) so as to not delay this series even
> further.
>
> Thanks for your work,