From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wolfram Sang <wsa@kernel.org>
Cc: Johan Hovold <johan@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Octavian Purdila <octavian.purdila@intel.com>,
Laurentiu Palcu <laurentiu.palcu@intel.com>,
linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] i2c: dln2: prevent buffer overflow in dln2_i2c_write()
Date: Wed, 12 Oct 2022 17:51:13 +0300 [thread overview]
Message-ID: <Y0bUYc2fadLgoQfZ@kili> (raw)
The "data_len" value is use controlled via the ioctl. It needs to
be bounds checked to prevent a buffer overflow.
Fixes: db23e5001f75 ("i2c: add support for Diolan DLN-2 USB-I2C adapter")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/i2c/busses/i2c-dln2.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/i2c/busses/i2c-dln2.c b/drivers/i2c/busses/i2c-dln2.c
index 2a2089db71a5..14f4aeeb263d 100644
--- a/drivers/i2c/busses/i2c-dln2.c
+++ b/drivers/i2c/busses/i2c-dln2.c
@@ -83,6 +83,9 @@ static int dln2_i2c_write(struct dln2_i2c *dln2, u8 addr,
BUILD_BUG_ON(sizeof(*tx) > DLN2_I2C_BUF_SIZE);
+ if (data_len > sizeof(tx->buf))
+ return -EINVAL;
+
tx->port = dln2->port;
tx->addr = addr;
tx->mem_addr_len = 0;
--
2.35.1
next reply other threads:[~2022-10-12 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 14:51 Dan Carpenter [this message]
2022-10-14 14:25 ` [PATCH] i2c: dln2: prevent buffer overflow in dln2_i2c_write() Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0bUYc2fadLgoQfZ@kili \
--to=dan.carpenter@oracle.com \
--cc=johan@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurentiu.palcu@intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox