From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Weilong Chen <chenweilong@huawei.com>
Cc: yangyicong@hisilicon.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, wsa@kernel.org,
f.fainelli@gmail.com, jarkko.nikula@linux.intel.com,
jdelvare@suse.de, william.zhang@broadcom.com, jsd@semihalf.com,
conor.dooley@microchip.com, phil.edworthy@renesas.com,
tharunkumar.pasumarthi@microchip.com, semen.protsenko@linaro.org,
kfting@nuvoton.com, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next v9 1/4] i2c: hisi: Add initial device tree support
Date: Mon, 31 Oct 2022 00:01:49 +0200 [thread overview]
Message-ID: <Y170TZoIp1WBIwU4@smile.fi.intel.com> (raw)
In-Reply-To: <20221029115937.179788-1-chenweilong@huawei.com>
On Sat, Oct 29, 2022 at 07:59:36PM +0800, Weilong Chen wrote:
> The HiSilicon I2C controller can be used on embedded platform, which
> boot from devicetree.
...
> +#include <linux/acpi.h>
> +#include <linux/of.h>
Why?
...
> +#ifdef CONFIG_ACPI
Why?
...
> +#ifdef CONFIG_OF
Why?
...
> - .acpi_match_table = hisi_i2c_acpi_ids,
> + .acpi_match_table = ACPI_PTR(hisi_i2c_acpi_ids),
Why?
...
> + .of_match_table = of_match_ptr(hisi_i2c_dts_ids),
Why of_match_ptr()?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-10-30 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 11:59 [PATCH next v9 1/4] i2c: hisi: Add initial device tree support Weilong Chen
2022-10-29 11:59 ` [PATCH next v9 2/4] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c Weilong Chen
2022-10-30 22:01 ` Andy Shevchenko [this message]
2022-10-31 1:57 ` [PATCH next v9 1/4] i2c: hisi: Add initial device tree support chenweilong
2022-10-31 15:42 ` Andy Shevchenko
2022-11-01 7:23 ` chenweilong
2022-11-01 14:43 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y170TZoIp1WBIwU4@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=chenweilong@huawei.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=jsd@semihalf.com \
--cc=kfting@nuvoton.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=william.zhang@broadcom.com \
--cc=wsa@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox