From: "wsa@kernel.org" <wsa@kernel.org>
To: Asmaa Mnebhi <asmaa@nvidia.com>
Cc: Ren Zhijie <renzhijie2@huawei.com>,
Khalil Blaiech <kblaiech@nvidia.com>,
Vadim Pasternak <vadimp@nvidia.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] i2c: mlxbf: Fix unused-variable warning
Date: Wed, 19 Oct 2022 21:44:21 +0200 [thread overview]
Message-ID: <Y1BTlflJKNS8JmI1@shikoro> (raw)
In-Reply-To: <CH2PR12MB3895C3FA56AE40EA043A0BCAD7209@CH2PR12MB3895.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 299 bytes --]
On Mon, Oct 10, 2022 at 12:00:09PM +0000, Asmaa Mnebhi wrote:
> Acked-by: Asmaa Mnebhi
You need to add your email address as well.
> If CONFIG_ACPI is not set,
Since DT support is gone now, shouldn't the driver actually depend on
ACPI now? Then, we could get rid of all the #ifdefs in the code?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-19 19:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 13:38 [PATCH -next] i2c: mlxbf: Fix unused-variable warning Ren Zhijie
2022-10-10 12:00 ` Asmaa Mnebhi
2022-10-19 19:44 ` wsa [this message]
2022-10-21 6:46 ` wsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1BTlflJKNS8JmI1@shikoro \
--to=wsa@kernel.org \
--cc=asmaa@nvidia.com \
--cc=kblaiech@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=renzhijie2@huawei.com \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox